Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to GHA, GHCR and add the linux-micro image #78

Merged
merged 6 commits into from
Apr 16, 2021
Merged

Conversation

pietroalbini
Copy link
Member

This PR makes multiple changes to this repository, hopefully improving the experience of using and contributing to crates-build-env:

  • The CI provider has been switched from Travis CI to GitHub Actions, as Travis CI occasionally fails to build PRs. The only notable difference is that container builds now start only after the linting process finishes, to avoid building containers when the packages.txt is not properly formatted.
  • The hosting for the container images has been switched from Docker Hub over to GitHub Container Registry. Docker Hub recently implemented fairly strict rate limits for unauthenticated downloads, and GHCR is nicely integrated with GitHub permissions and GitHub Actions. The image on Docker Hub will remain available but will not be updated anymore.
  • A new container image was added: linux-micro. The container image just installs build-essentials and libssl-dev (OpenSSL), and it's meant to be used for local development and test suites. This should make the experience of contributing to Crater and docs.rs less painful.
  • The README was updated to reflect these changes.

After this PR is merged, Rustwide will need to be updated to point to GHCR, and tools will need to download the Docker images with these commands:

docker pull ghcr.io/rust-lang/crates-build-env/linux:latest
docker pull ghcr.io/rust-lang/crates-build-env/linux-micro:latest

r? @jyn514

linux/Dockerfile Outdated Show resolved Hide resolved
lint.sh Show resolved Hide resolved
windows/ci/build.ps1 Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@pietroalbini
Copy link
Member Author

Addressed all feedback @jyn514!

linux-micro/Dockerfile Outdated Show resolved Hide resolved
@jyn514
Copy link
Member

jyn514 commented Apr 16, 2021

r=me with that last nit addressed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants