Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor worker #736

Merged
merged 2 commits into from
Aug 31, 2024
Merged

Refactor worker #736

merged 2 commits into from
Aug 31, 2024

Conversation

Mark-Simulacrum
Copy link
Member

This moves all pushes of logs to the central server out of the execution
of tasks and into the worker function, which ensures that we don't
overwrite previous results for the same crate multiple times (when
retrying its run). That should hopefully preserve the logs as well
throughout the retries.

@Mark-Simulacrum
Copy link
Member Author

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 31, 2024

📌 Commit cca4c3f has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Aug 31, 2024

⌛ Testing commit cca4c3f with merge ba77697...

bors added a commit that referenced this pull request Aug 31, 2024
Refactor worker

This moves all pushes of logs to the central server out of the execution
of tasks and into the worker function, which ensures that we don't
overwrite previous results for the same crate multiple times (when
retrying its run). That should hopefully preserve the logs as well
throughout the retries.
@bors
Copy link
Collaborator

bors commented Aug 31, 2024

💔 Test failed - checks-actions

This moves all pushes of logs to the central server out of the execution
of tasks and into the worker function, which ensures that we don't
overwrite previous results for the same crate multiple times (when
retrying its run). That should hopefully preserve the logs as well
throughout the retries.
@Mark-Simulacrum
Copy link
Member Author

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 31, 2024

📌 Commit d9bc6ab has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Aug 31, 2024

⌛ Testing commit d9bc6ab with merge 1cbbe32...

@bors
Copy link
Collaborator

bors commented Aug 31, 2024

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 1cbbe32 to master...

@bors bors merged commit 1cbbe32 into rust-lang:master Aug 31, 2024
3 checks passed
@Mark-Simulacrum Mark-Simulacrum deleted the refactor-worker branch August 31, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants