Skip to content

Only write regressed crates as raw logs #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from

Conversation

Mark-Simulacrum
Copy link
Member

This avoids a whole bunch of time writing logs for every crate out there. We
could optimize the writing itself (e.g., doing it in parallel would likely be a
huge win), but in practice there's no real need for each individual crate to
have its own file in S3, and that has other costs that would be nice to avoid
(e.g., compression is much less practical).

We can add support at a later point for the HTML reports to link to some server
(or lambda, whatever) that processes the tarball and serves results from it. It
takes around ~3 seconds to cat an all-crate zstd-compressed tarball, which takes up 400 MB.
3 seconds is probably too long for point queries to be viable on a re-download
and decompress, but that kind of speed means that it's not infeasible for us
to query on demand with some lightweight improvements to that process.

Copy link
Member

@pietroalbini pietroalbini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change looks good, but we'll also want to remove the now-dangling links to the logs in the report UI (templates/macros.html iirc) if the crate did not regress.

@Mark-Simulacrum
Copy link
Member Author

I think that's one route, but I personally prefer that we just drop the all.html summary; the raw data is still going to be present in JSON (results.json) and in the all tarball; I think that's sufficient.

Also adjusted so that logs for everything present in the summary report are included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants