Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an example of passing rustflags to docs #581

Merged
merged 1 commit into from
Feb 21, 2022
Merged

Add an example of passing rustflags to docs #581

merged 1 commit into from
Feb 21, 2022

Conversation

Mark-Simulacrum
Copy link
Member

This avoids confusion with the {} brackets being actually necessary, leading
to configuring a run in which they are directly passed to rustc.

This avoids confusion with the `{}` brackets being actually necessary, leading
to configuring a run in which they are directly passed to rustc.
@Mark-Simulacrum
Copy link
Member Author

cc rust-lang/rust#85530 (comment) -- not yet handled case. Probably suggests switching away from {foo} to e.g. $foo might make sense across the whole docs.

@eddyb
Copy link
Member

eddyb commented Jul 18, 2021

cc rust-lang/rust#85530 (comment) -- not yet handled case. Probably suggests switching away from {foo} to e.g. $foo might make sense across the whole docs.

FWIW what tripped me up in that case, was that crates=list:https://git.io/Jes7o was one of the examples (though with crates= implied, not explicit), but when using an URL to a text file, for that purpose, the list: part shouldn't actually be included (which makes sense, the : means it can be disambiguated from an URL).

@Mark-Simulacrum
Copy link
Member Author

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 21, 2022

📌 Commit b991f05 has been approved by Mark-Simulacrum

@bors
Copy link
Collaborator

bors commented Feb 21, 2022

⌛ Testing commit b991f05 with merge c899b6f...

@bors
Copy link
Collaborator

bors commented Feb 21, 2022

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing c899b6f to master...

@bors bors merged commit c899b6f into rust-lang:master Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants