report private repository error as broken crate #453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pietroalbini
requested changes
Sep 7, 2019
Member
pietroalbini
left a comment
pietroalbini
left a comment
There was a problem hiding this comment.
Can we also add a minicrater test to ensure private repos are probably detected? https://github.com/ghost/doesnt-exist is a good candidate for it.
zeegomo
force-pushed
the
broken-private-repo
branch
from
dad8ceb to
2dc801d
Compare
pietroalbini
approved these changes
Sep 17, 2019
Member
pietroalbini
left a comment
pietroalbini
left a comment
There was a problem hiding this comment.
Thanks! I'll hold off merging until rustwide 0.3.0 is released so we can remove the git dependency, but this looks great!
Contributor
|
☔ The latest upstream changes (presumably #462) made this pull request unmergeable. Please resolve the merge conflicts. |
zeegomo
force-pushed
the
broken-private-repo
branch
from
2dc801d to
443bdf8
Compare
Member
|
Thanks! @bors r+ |
Contributor
|
📌 Commit 443bdf8 has been approved by |
Contributor
bors
added a commit
that referenced
this pull request
Sep 24, 2019
report private repository error as broken crate Change crate result from `Error` to `Broken` if the crate repo is private or not available.
Contributor
|
💔 Test failed - checks-travis |
Member
|
@bors retry |
Contributor
bors
added a commit
that referenced
this pull request
Sep 24, 2019
report private repository error as broken crate Change crate result from `Error` to `Broken` if the crate repo is private or not available.
Contributor
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change crate result from
ErrortoBrokenif the crate repo is private or not available.