Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for the riscv64-linux-android target #640

Closed
2 of 3 tasks
chriswailes opened this issue Jun 22, 2023 · 7 comments · Fixed by rust-lang/rust#112858
Closed
2 of 3 tasks

Add support for the riscv64-linux-android target #640

chriswailes opened this issue Jun 22, 2023 · 7 comments · Fixed by rust-lang/rust#112858
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team

Comments

@chriswailes
Copy link

chriswailes commented Jun 22, 2023 •
edited by pnkfelix
Loading

Proposal

The Android team would like to add support for the riscv64-linux-android target. We've been building and testing a local version of this patch for several releases and are ready to upstream these changes to support experimental development for the target.

Mentors or Reviewers

chriswailes

Process

The main points of the Major Change Process are as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however, you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Comments

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.
@chriswailes chriswailes added major-change A proposal to make a major change to rustc T-compiler Add this label so rfcbot knows to poll the compiler team labels Jun 22, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jun 22, 2023

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

cc @rust-lang/compiler @rust-lang/compiler-contributors

@rustbot rustbot added the to-announce Announce this issue on triage meeting label Jun 22, 2023
@chriswailes chriswailes mentioned this issue Jun 22, 2023
Merged
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Jun 23, 2023
@oli-obk
Copy link
Contributor

oli-obk commented Jun 23, 2023

@rustbot second

@rustbot rustbot added the final-comment-period The FCP has started, most (if not all) team members are in agreement label Jun 23, 2023
@Amanieu
Copy link
Member

Amanieu commented Jun 27, 2023

My understanding is that Android will end up requiring a larger set of features than the base GC RISC-V profile. Does this target intend to track the upstream target requirements, in which case this should be considered more of a "beta" target until the exact feature requirements for Android are nailed down?

@chriswailes
Copy link
Author

You are correct on all accounts. Is "beta" an alternative to "Tier 3"?

@the8472
Copy link
Member

the8472 commented Jun 28, 2023

Wasi is switching to a -preview<number> suffix. See #607

@riking
Copy link

riking commented Jul 8, 2023

"Target is beta" is something you would describe in the target support document.

@wesleywiser
Copy link
Member

@rustbot label -final-comment-period +major-change-accepted

@rustbot rustbot added major-change-accepted A major change proposal that was accepted to-announce Announce this issue on triage meeting and removed final-comment-period The FCP has started, most (if not all) team members are in agreement labels Jul 21, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Jul 31, 2023
@matthiaskrgr
Rollup merge of rust-lang#112858 - chriswailes:riscv64-android, r=Mar…
f478ea5 
…k-Simulacrum

Update Android system definitions and add riscv-linux-android as tier 3 target

This PR includes the following:
* Corrected Android system definitions for some types
* Support for the riscv64-linux-android target

The authoritative types for the system definitions can be found here: https://cs.android.com/android/platform/superproject/+/master:bionic/libc/include/sys/stat.h

Fixes rust-lang/compiler-team#640
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Jul 31, 2023
@matthiaskrgr
Rollup merge of rust-lang#112858 - chriswailes:riscv64-android, r=Mar…
63ab1fa 
…k-Simulacrum

Update Android system definitions and add riscv-linux-android as tier 3 target

This PR includes the following:
* Corrected Android system definitions for some types
* Support for the riscv64-linux-android target

The authoritative types for the system definitions can be found here: https://cs.android.com/android/platform/superproject/+/master:bionic/libc/include/sys/stat.h

Fixes rust-lang/compiler-team#640
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Jul 31, 2023
@matthiaskrgr
Rollup merge of rust-lang#112858 - chriswailes:riscv64-android, r=Mar…
d0ae0b3 
…k-Simulacrum

Update Android system definitions and add riscv-linux-android as tier 3 target

This PR includes the following:
* Corrected Android system definitions for some types
* Support for the riscv64-linux-android target

The authoritative types for the system definitions can be found here: https://cs.android.com/android/platform/superproject/+/master:bionic/libc/include/sys/stat.h

Fixes rust-lang/compiler-team#640
github-actions bot pushed a commit to rust-lang/miri that referenced this issue Aug 2, 2023
@matthiaskrgr
Rollup merge of #112858 - chriswailes:riscv64-android, r=Mark-Simulacrum
78dadb4 
Update Android system definitions and add riscv-linux-android as tier 3 target

This PR includes the following:
* Corrected Android system definitions for some types
* Support for the riscv64-linux-android target

The authoritative types for the system definitions can be found here: https://cs.android.com/android/platform/superproject/+/master:bionic/libc/include/sys/stat.h

Fixes rust-lang/compiler-team#640
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Aug 4, 2023
thomcc pushed a commit to tcdi/postgrestd that referenced this issue Oct 17, 2023
@matthiaskrgr
Rollup merge of #112858 - chriswailes:riscv64-android, r=Mark-Simulacrum
c8fe0cf 
Update Android system definitions and add riscv-linux-android as tier 3 target

This PR includes the following:
* Corrected Android system definitions for some types
* Support for the riscv64-linux-android target

The authoritative types for the system definitions can be found here: https://cs.android.com/android/platform/superproject/+/master:bionic/libc/include/sys/stat.h

Fixes rust-lang/compiler-team#640
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Android system definitions and add riscv-linux-android as tier 3 target chriswailes/rust
8 participants
@Amanieu @oli-obk @chriswailes @riking @wesleywiser @the8472 @apiraino @rustbot