Skip to content

Conversation

@mati865
Copy link
Member

@mati865 mati865 commented Jan 7, 2026

Similarly to i686 and X86_64 MinGW targets, Rust needs to provide the right chkstk symbol for AArch64 to avoid relying on the linker to provide it.

CC rust-lang/rust#150725

Similarly to i686 and X86_64 MinGW targets, Rust needs to provide the
right chkstk symbol for AArch64 to avoid relying on the linker to
provide it.

CC rust-lang/rust#150725
@mati865 mati865 force-pushed the aarch64-mingw-chkstk branch from 114d5a7 to 00a4313 Compare January 7, 2026 13:46
@rustbot
Copy link
Collaborator

rustbot commented Jan 7, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@tgross35
Copy link
Contributor

tgross35 commented Jan 7, 2026

Just to cross reference, does LLVM compiler-rt and/or libgcc provide this?

@mati865
Copy link
Member Author

mati865 commented Jan 7, 2026

Yeah, they do. LLVM code might be hard to read without proficiency, so posting symbol dump instead:

$ nm -A /g/msys64/opt/llvm-mingw-20251216-ucrt-x86_64/lib/clang/21/lib/windows/libclang_rt.builtins-* | rg chkstk
G:/msys64/opt/llvm-mingw-20251216-ucrt-x86_64/lib/clang/21/lib/windows/libclang_rt.builtins-aarch64.a:chkstk.S.obj: 00000000 T #__chkstk_arm64ec
G:/msys64/opt/llvm-mingw-20251216-ucrt-x86_64/lib/clang/21/lib/windows/libclang_rt.builtins-aarch64.a:chkstk.S.obj: 00000000 T __chkstk
G:/msys64/opt/llvm-mingw-20251216-ucrt-x86_64/lib/clang/21/lib/windows/libclang_rt.builtins-arm.a:chkstk.S.obj: 00000000 T __chkstk
G:/msys64/opt/llvm-mingw-20251216-ucrt-x86_64/lib/clang/21/lib/windows/libclang_rt.builtins-i386.a:chkstk.S.obj: 00000000 T __alloca
G:/msys64/opt/llvm-mingw-20251216-ucrt-x86_64/lib/clang/21/lib/windows/libclang_rt.builtins-x86_64.a:chkstk.S.obj: 00000000 T ___chkstk_ms

GCC support for AArch64 is experimental, so I didn't bother finding toolchain to check it.

Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tgross35 tgross35 merged commit 65624df into rust-lang:main Jan 8, 2026
39 checks passed
@mati865 mati865 deleted the aarch64-mingw-chkstk branch January 8, 2026 10:37
@mati865
Copy link
Member Author

mati865 commented Jan 8, 2026

Thanks. May I ask when typically the builtins subtree is synced to the main repo?

@tgross35
Copy link
Contributor

tgross35 commented Jan 8, 2026

It's in progress, just had to wait on CI 👍

@mati865
Copy link
Member Author

mati865 commented Jan 8, 2026

Oh, no worries. I was just curious how long it takes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants