Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test for bug with mixed cycles #788

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Jan 16, 2023

No description provided.

Comment on lines +357 to +358
(): C<T>,
(): B<T>,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apparently nested obligations are checked in reverse order '^^, first looking at (): B<T> and then (): C<T>.

@compiler-errors
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 11, 2023

📌 Commit c53bcac has been approved by compiler-errors

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Apr 11, 2023

⌛ Testing commit c53bcac with merge 0ecdd7f...

@bors
Copy link
Collaborator

bors commented Apr 11, 2023

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 0ecdd7f to master...

@bors bors merged commit 0ecdd7f into rust-lang:master Apr 11, 2023
@lcnr lcnr deleted the mixed-cycle-broken branch April 12, 2023 07:22
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 8, 2023
…errors

add provisional cache test for new solver

wrote it for chalk in rust-lang/chalk#788 and never added it to the new solver.

r? `@compiler-errors`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 8, 2023
…errors

add provisional cache test for new solver

wrote it for chalk in rust-lang/chalk#788 and never added it to the new solver.

r? ``@compiler-errors``
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants