Some cleanups and add a solve_limited
#321
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could be two separate PRs, but the cleanups are small:
InferenceTableontoContextdirectly, since they don't need an&selfany_future_answertake a&selfinstead of a&mut selfThe bulk of the PR involves adding a
should_continueargument topeek_answerandnext_answer, which allows stopping of solving before an answer is ready, when aQuantumExceededhas been returned. Right now, it's a argument-less function, so there's no real "feedback", so it's pretty much limited to either a time-based or call number-based implementation.However, some ideas for how to extend this:
falseis returned. Right now, the returned answer is the current substitution asGuidance(Suggested(...)). Instead, we could take into account the possible answers (similar to howany_future_answerworks). Or, maybe we just returnNoneinstead.