Separate Program from ProgramEnvironment. #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes rust-lang#19. I took a slightly different approach from your suggestion. ir::Program and ProgramEnvironment are distinct types with no ownership relationship, but instead of lowering returning a tuple, ir::Program has a method to construct a ProgramEnvironment. In addition to the trait_data, the associated_type_data also needs to be cloned over, and the `split_projection` method is duplicated for both types, because that method is invoked in `elaborated_clauses`. It seems like once we have a new way of solving rust-lang#12, ProgramEnvironment would just be a set of ProgramClauses, and that would be the whole context necessary for the solver to run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19. I took a slightly different approach from your suggestion.
ir::Program and ProgramEnvironment are distinct types with no ownership
relationship, but instead of lowering returning a tuple, ir::Program
has a method to construct a ProgramEnvironment.
In addition to the trait_data, the associated_type_data also needs to
be cloned over, and the
split_projectionmethod is duplicated forboth types, because that method is invoked in
elaborated_clauses.It seems like once we have a new way of solving #12, ProgramEnvironment
would just be a set of ProgramClauses, and that would be the whole
context necessary for the solver to run.