Skip to content

Commit

Permalink
this is fine
Browse files Browse the repository at this point in the history
  • Loading branch information
pierwill committed Dec 17, 2021
1 parent d270a5e commit 814d41f
Showing 1 changed file with 0 additions and 12 deletions.
12 changes: 0 additions & 12 deletions chalk-solve/src/coherence.rs
Original file line number Diff line number Diff line change
Expand Up @@ -61,18 +61,6 @@ impl<I: Interner> SpecializationPriorities<I> {
/// Store the priority of an impl (used during construction).
/// Panics if we have already stored the priority for this impl.
fn insert(&mut self, impl_id: ImplId<I>, p: SpecializationPriority) {
// FIXME:
// Previously, the code was:
//
// ```
// let old_value = self.map.insert(impl_id, p);
// assert!(old_value.is_none());
// ```
//
// `SpecializationPriority::build_specialization_forest`
// has a check to ensure we don't add duplicate nodes.
// *However*, The tests only pass after removing the assertion here.
// We should make sure this is correct.
self.map.insert(impl_id, p);
}
}
Expand Down

0 comments on commit 814d41f

Please sign in to comment.