Fix use of cc with make <4.3: Clear O_NONBLOCK after compilaton #966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since make <4.3 cannot handle jobserver pipe with `O_NONBLOCK` set. Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
|
@nadenf @IGI-111 Could you please try this PR, to see if it fixed the error when used with make <4.3 ? |
|
I can indeed confirm this fixes my issue. |
This was referenced Feb 23, 2024
Amanieu
reviewed
Feb 24, 2024
Amanieu
approved these changes
Feb 24, 2024
NobodyXu
changed the title
All unix, not just linux, has /dev/fd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #962
make <4.3 cannot handle jobserver pipe with
O_NONBLOCKset.