Some clippy fixes

[waywardmonkeys]

No description provided.

[madsmtm]

Perhaps it'd make sense to add clippy to CI?

[NobodyXu]

Yes it does, if you are fixing the clippy then it makes sense to also add it to the CI.

[waywardmonkeys]

I'll rebase this, see if I had fixed everything, and if so, add it to CI.

[waywardmonkeys]

There are still a number of clippy warnings, so that's why I hadn't enabled it in CI yet.

[workingjubilee]

Can you add a test that only fails on clippy errors, then? Clippy doesn't default-error for a lot, but on the things it does error for, they're pretty bad.

[NobodyXu]

Hi, I agree with @workingjubilee that adding clippy run that failed on clippy errors in CI is required for this PR to merge.

If you are willing to add that, I'm willing to approve and merge it.

[waywardmonkeys]

I will work on it!

[waywardmonkeys]

For better or worse, the if_same_then_else were errors (but I called them warnings in the commit message, I'll change that).

So they have to be fixed to add the new CI job.

@NobodyXu This should be re-ready for review.

There's still a bunch of clippy warnings ...

[NobodyXu]

LGTM, having warning is ok