Separate source args with -- when compiling assembly with clang-cl #857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, when compiling with clang-cl, we separate the source from the arguments by inserting a `--`. This avoids compilation errors due to conflicts between source paths and arguments (especially on macos, where path will often begin with /Users, but /U is a clang-cl flag). However, this separator is disabled when we are compiling assembly for msvc targets, as those will usually be compiled through `ml.exe`, which doesn't understand this separator. Problem is, this is not always the case: Only `.asm` files are compiled using `ml.exe`. Any asm using a different extension will still go through the normal C compiler (clang-cl), and hence we need to provide the separator in that case.
thomcc
approved these changes
Sep 1, 2023
Member
thomcc
left a comment
thomcc
left a comment
There was a problem hiding this comment.
Yeah, I see. I wish we had tests for this but so it goes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when compiling with clang-cl, we separate the source from the arguments by inserting a
--. This avoids compilation errors due to conflicts between source paths and arguments (especially on macos, where path will often begin with /Users, but /U is a clang-cl flag).However, this separator is disabled when we are compiling assembly for msvc targets, as those will usually be compiled through
ml.exe, which doesn't understand this separator. Problem is, this is not always the case: Only.asmfiles are compiled usingml.exe. Any asm using a different extension will still go through the normal C compiler (clang-cl), and hence we need to provide the separator in that case.