Skip to content

MSVC: Add LIB var when compiling flag_check #1417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 26, 2025
Merged

MSVC: Add LIB var when compiling flag_check #1417

merged 1 commit into from
Feb 26, 2025

Conversation

@ChrisDenton
Copy link
Member

Fixes #1416

@ChrisDenton ChrisDenton mentioned this pull request Feb 26, 2025
Closed
NobodyXu
NobodyXu requested changes Feb 26, 2025
View reviewed changes
NobodyXu
NobodyXu approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@NobodyXu NobodyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick fix!

It will be released on Friday/Saturday

@NobodyXu NobodyXu merged commit 8127db1 into rust-lang:main Feb 26, 2025
73 checks passed
@ChrisDenton ChrisDenton deleted the flag_check_crt branch February 26, 2025 10:54
@github-actions github-actions bot mentioned this pull request Feb 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NobodyXu NobodyXu NobodyXu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: Build::is_flag_supported /guard:cf returns false on 1.2.4 ->1.2.5 transition (on x86_64-pc-windows-msvc)

2 participants

@ChrisDenton @NobodyXu