Check linking when testing if compiler flags are supported #1322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomcc
approved these changes
Dec 17, 2024
|
Can we get this published as a patch release, or are there plans around when to cut the next release? Asking since this currently blocks rust-lang/rust#134419, which in turn blocks rust-lang/rust#133794 |
|
cc will create one release PR every Saturday, and then I can merge and release it. I could release this early if it is urgent |
|
Cool. I did not know you had that weekly cadence. I think it would be nice if we can make the bump in |
Merged
|
Given that it's a bug affecting rustc and might affect rustc's next release, I will cut a release now to ensure you'd have that in. |
|
cc @clubby789 @faern new patch release containing the fix has released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1321
Several of the inherited flags affect the linker, so we do need to go all the way to linking to verify them