Fix msvc stdout not shown on error

[NobodyXu]

Fixed #1260

[madsmtm]

Why do this in create_compile_object_cmd (and not more generally in try_get_compiler)?

[NobodyXu]

Hmmm I didn't think of this at all!

Looking at it closer, I think there are two reasons not to do that:

• try_get_compiler is a public function, changing it might break someone else's workflow, i.e. what if user actually expects non-English output?
  try_get_compiler only adds args not env, while create_compile_object_cmds does add env (for apple only though). I guess this also has to do with try_get_compiler being public interface?
• Upon further checking try_get_compiler is used in try_expand and is_flag_supported_inner, which checks for exit code and stderr output of the compiler https://docs.rs/cc/latest/src/cc/lib.rs.html#713 , add env that changes stdout/stderr might break it

[madsmtm]

what if user actually expects non-English output

If we consider changing the shown language a breaking change, then changing it in create_compile_object_cmd is also a breaking change, no?

try_get_compiler only adds args not env, while create_compile_object_cmds does add env (for apple only though)

I doubt there's a thought-out reason for that? In any case, I'm pretty sure that workaround can be removed nowadays (the problem was using the general *-apple-darwin target instead of the specific *-apple-macosx target).

Upon further checking try_get_compiler is used in try_expand and is_flag_supported_inner, which checks for exit code and stderr output of the compiler https://docs.rs/cc/latest/src/cc/lib.rs.html#713 , add env that changes stdout/stderr might break it

Those all seem positive to force being English (provided we decide to force English at all)?

[madsmtm]

Why only when linking for MSVC? Seems like we'd want to do this everywhere, if we wanted to do it in the first place?

[NobodyXu]

Thanks updated.

[NobodyXu]

If we consider changing the shown language a breaking change, then changing it in create_compile_object_cmd is also a breaking change, no?

yes that's true.

Those all seem positive to force being English (provided we decide to force English at all)?

Yeah, thanks, I've changed it to be set in try_get_compiler