Fix compile family detection: Use C macros instead of $compiler -v
#1000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jiahao XU <[email protected]>
which is more robust than checking output of `$compiler -v` Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
When expanding the file, the compiler prints a lot of information to stderr that it is not an error, but related to expanding itself. cc would have to disable warning here to prevent generation of too many warnings. Signed-off-by: Jiahao XU <[email protected]>
…utput is enabled It's good to have the output for debugging. Signed-off-by: Jiahao XU <[email protected]>
…abled Can help find issues related to compiler family detection. Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
Fallback to create `NamedTempfile` in `std::env::temp_dir()` Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
It's not necessary. Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
Be-ing
reviewed
Mar 9, 2024
Closed
Signed-off-by: Jiahao XU <[email protected]>
This was referenced Mar 16, 2024
Signed-off-by: Jiahao XU <[email protected]>
workingjubilee
approved these changes
Mar 17, 2024
Member
workingjubilee
left a comment
workingjubilee
left a comment
There was a problem hiding this comment.
Seems to work locally. Can't attest to Windows correctness, but we'll find out very quickly if it isn't.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #958