Changelog for 1.2.43?

[Kriskras99]

Changelog.md is missing 1.2.43 and the Github release contains the changelog of 1.2.42.

There have been two commits since 1.2.42:

• Mark static_flag and shared_flag as deprecated
• Stop passing an invalid target to llvm-mingw's cross-compilation wrappers

But there is no release commit, so it's unclear to me if both commits are in the new release.

[AlexTMjugador]

It looks like 1.2.43 contains commit a0b2fd6, but not 8a45e2b, so people interested in getting the latter commit in a release (like me 😇) will have to wait until a new release is made, or the situation you describe with 1.2.43 is sorted out.

[NobodyXu]

It looks like somehow the release commit is wrong fdb089a

It's auto-generated by release-plz, so no ideally what's going on and we can't just rewrite history of main

[Kriskras99]

But that commit is for 1.2.42 which is correct. There is no release-plz PR (open or closed) for 1.2.43.

[Kriskras99]

There's also no relevent CI job after 1.2.42 (https://github.com/rust-lang/cc-rs/actions)

[NobodyXu]

But that commit is for 1.2.42 which is correct. There is no release-plz PR (open or closed) for 1.2.43.

The commit message is probably wrong?

It might be for 1.2.43, otherwise we won't have 1.2.43 release tag and crates.io publish

[Kriskras99]

I think I figured out. By inspecting the Cargo VCS metadata I've found the following:

• 1.2.42 is fdb089a
• 1.2.43 is a0b2fd6

The reason release-plz published a new version is because commit a0b2fd6 changed the version number. This is what release-plz uses to know if it needs to publish a new version (see the CI job).

The reason the changelog is incorrect, is that release-plz assumes the changelog was updated and just takes the last section.

To prevent this happening again, PRs should not increment the version number.

[NobodyXu]

Thanks, I didn't remember merging a PR bumping version number, I must have missed it

[AlexTMjugador]

Out of curiosity, was 8a45e2b intended to be released as a part of 1.2.43? Of course, I'm aware we can't/shouldn't modify the release in place now, but it does seem to me that it was missed from 1.2.43 on accident.

[Kriskras99]

There wasn't supposed to be a 1.2.43 (at least not yet), this release was unplanned. It happened because an outside contributor unfamiliar with release-plz bumped the version number in a PR.

[NobodyXu]

Out of curiosity, was 8a45e2b intended to be released as a part of 1.2.43?

No definitely not, 1.2.43 was supposed to release on this Friday.