Move string interning to util #8419
Conversation
Code that handles string interning is rather an util functionality than a core functionality.
The leak function is never used outside of interning.rs and I don't think it makes any sense to use it.
|
r? @ehuss (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
I have been seeing advice lately not to name a mod "misc" because "in a year it will be completely unclear what belongs in it". Thank you @est31 for starting to talk about this long standing teck det, What belongs in "util"? The status quo is not really ok. I know Eric had opinions, so I am glad he is the reviewer. My prior belief is that we should be reorganizing to not have a "util" but to have things is mods that describe what they do. On the other hand if this helps untangle our mods, "don't let the perfect be the enemy of the good", we can move interning if it is helpful. |
|
IMO interning fits to be next to mods like Of course there's plenty of stuff in util that contains very cargo-specific stuff, like the config and toml modules. IMO those two should be put into a separate newly created module called defs which would collect most pure datatypes that just need serde and nothing much else. The command prelude can be put into the bin directory. And suddenly most dependencies of util on the core module are gone, and util can be put into its own crate. The defs module then can be crate-ified as well, and depend on util. The main cargo crate would depend on all of them and be a bit leaner than it's now. I need to experiment how this affects compile time. Hopefully serde-using stuff being moved out has a large effect. |
|
One thing I would eventually like to reach is to remove the cyclical dependency with I'm 👍 for doing this. @alexcrichton / @Eh2406 are you OK with this? |
|
I am convinced by @est31's vition for how to get untangled. So I am 👍. |
|
I don't have too many preferences about Cargo's internal organization, we've never really put too much effort into organizing it any particular way. I don't really think it's worth it to try to micro-optimize one way or another because we don't really have an overall vision for the crate. I'm not really against nor in favor of this, it's just moving code around which is fine by me so long as we don't have a preexisting style saying the code shouldn't be moved (and we don't have a such a preexisting style in this case) |
|
OK, I think this is fine for now. I think it may help with creating separate crates in the future. @bors r+ |
|
📌 Commit 836e91c has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-azure |
Update cargo ## cargo 10 commits in c26576f9adddd254b3dd63aecba176434290a9f6..305eaf0dc5f5a38d6e8041319c2da95b71cf6a4a 2020-06-23 16:21:21 +0000 to 2020-06-30 14:16:08 +0000 - Update core-foundation requirement from 0.7.0 to 0.9.0 (rust-lang/cargo#8432) - Parse `# env-dep` directives in dep-info files (rust-lang/cargo#8421) - Move string interning to util (rust-lang/cargo#8419) - Expose built cdylib artifacts in the Compilation structure (rust-lang/cargo#8418) - Remove unused serde_derive dependency from the crates.io crate (rust-lang/cargo#8416) - Remove unused remove_dir_all dependency (rust-lang/cargo#8412) - Improve git error messages a bit (rust-lang/cargo#8409) - Improve the description of Config.home_path (rust-lang/cargo#8408) - Improve support for non-`master` main branches (rust-lang/cargo#8364) - Document that OUT_DIR in JSON messages is an absolute path (rust-lang/cargo#8403) ## rls 2020-06-19 15:36:00 +0200 to 2020-06-30 23:34:52 +0200 - Update cargo (rust-lang/rls#1686)
Update cargo, rls ## cargo 14 commits in c26576f9adddd254b3dd63aecba176434290a9f6..fede83ccf973457de319ba6fa0e36ead454d2e20 2020-06-23 16:21:21 +0000 to 2020-07-02 21:51:34 +0000 - Fix overflow error on 32-bit. (rust-lang/cargo#8446) - Exclude the target directory from backups using CACHEDIR.TAG (rust-lang/cargo#8378) - CONTRIBUTING.md: Link to Zulip rather than Discord (rust-lang/cargo#8436) - Update built-in help for features (rust-lang/cargo#8433) - Update core-foundation requirement from 0.7.0 to 0.9.0 (rust-lang/cargo#8432) - Parse `# env-dep` directives in dep-info files (rust-lang/cargo#8421) - Move string interning to util (rust-lang/cargo#8419) - Expose built cdylib artifacts in the Compilation structure (rust-lang/cargo#8418) - Remove unused serde_derive dependency from the crates.io crate (rust-lang/cargo#8416) - Remove unused remove_dir_all dependency (rust-lang/cargo#8412) - Improve git error messages a bit (rust-lang/cargo#8409) - Improve the description of Config.home_path (rust-lang/cargo#8408) - Improve support for non-`master` main branches (rust-lang/cargo#8364) - Document that OUT_DIR in JSON messages is an absolute path (rust-lang/cargo#8403) ## rls 2020-06-19 15:36:00 +0200 to 2020-06-30 23:34:52 +0200 - Update cargo (rust-lang/rls#1686)
Code that handles string interning is rather an util functionality than
a core functionality.