Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remap-path-prefix from failing. #7219

Merged
merged 1 commit into from
Aug 6, 2019

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Aug 6, 2019

rustc currently remaps the source paths in the dep-info file, causing them to potentially point to a non-existent path. This causes the call to canonicalize added in #7137 to fail. Just ignore the error.

Closes #7211

@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 6, 2019
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Collaborator

bors commented Aug 6, 2019

📌 Commit ec9222a has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 6, 2019
@bors
Copy link
Collaborator

bors commented Aug 6, 2019

⌛ Testing commit ec9222a with merge e20a199...

bors added a commit that referenced this pull request Aug 6, 2019
Fix remap-path-prefix from failing.

rustc currently remaps the source paths in the dep-info file, causing them to potentially point to a non-existent path. This causes the call to `canonicalize` added in #7137 to fail.  Just ignore the error.

Closes #7211
@bors
Copy link
Collaborator

bors commented Aug 6, 2019

☀️ Test successful - checks-azure
Approved by: alexcrichton
Pushing e20a199 to master...

@bors bors merged commit ec9222a into rust-lang:master Aug 6, 2019
bors added a commit to rust-lang/rust that referenced this pull request Aug 8, 2019
Update cargo

9 commits in 26092da337b948719549cd5ed3d1051fd847afd7..42a8c0adf91323c01228268c651aef5366b25b69
2019-07-31 23:24:32 +0000 to 2019-08-07 20:41:07 +0000
- Add support for customizing JSON diagnostics from Cargo (rust-lang/cargo#7214)
- Bump rustfix (rust-lang/cargo#7221)
- Fix remap-path-prefix from failing. (rust-lang/cargo#7219)
- Clean up build script stuff and documentation. (rust-lang/cargo#7215)
- Remove debug panic in package-features. (rust-lang/cargo#7213)
- Fix an old test. (rust-lang/cargo#7208)
- Remove unused AstBuilder (rust-lang/cargo#7210)
- Revert "Release a jobserver token while locking a file" (rust-lang/cargo#7201)
- improve error message for unmatched prerelease dependencies (rust-lang/cargo#7191)
@ehuss ehuss added this to the 1.38.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cargo nightly build with RUSTFLAGS having --remap-path-prefix broke since last nightly on Windows
4 participants