-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to implement platform features #1197 #6286
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Thanks for the PR! Unfortunately though at this time Cargo is in a soft feature freeze state so I don't think the Cargo team will be able to get around to this in the near future and decide whether we'd like to include this or not |
No worries. As long as it hangs around and is mergeable, I don't mind. |
☔ The latest upstream changes (presumably #6336) made this pull request unmergeable. Please resolve the merge conflicts. |
# Conflicts: # src/cargo/core/compiler/build_context/mod.rs # src/cargo/core/compiler/context/unit_dependencies.rs # src/cargo/core/dependency.rs # src/cargo/core/package.rs # src/cargo/core/resolver/context.rs # src/cargo/core/resolver/mod.rs # src/cargo/core/resolver/resolve.rs # src/cargo/core/summary.rs # src/cargo/ops/cargo_output_metadata.rs # src/cargo/util/toml/mod.rs
Patch updated to match the current master. |
☔ The latest upstream changes (presumably #6416) made this pull request unmergeable. Please resolve the merge conflicts. |
☔ The latest upstream changes (presumably #6425) made this pull request unmergeable. Please resolve the merge conflicts. |
☔ The latest upstream changes (presumably #6687) made this pull request unmergeable. Please resolve the merge conflicts. |
☔ The latest upstream changes (presumably #6653) made this pull request unmergeable. Please resolve the merge conflicts. |
☔ The latest upstream changes (presumably #6842) made this pull request unmergeable. Please resolve the merge conflicts. |
I think this has become somewhat bitrotted over time and stale, so I'm going to close this. If you'd like to resubmit it though with a rebase plase feel free to do so! |
r? @alexcrichton