Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to implement platform features #1197 #6286

Closed
wants to merge 14 commits into from

Conversation

snuk182
Copy link

@snuk182 snuk182 commented Nov 8, 2018

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@snuk182 snuk182 changed the title Attempt to implement #1197 Attempt to implement platform features #1197 Nov 8, 2018
@alexcrichton
Copy link
Member

Thanks for the PR! Unfortunately though at this time Cargo is in a soft feature freeze state so I don't think the Cargo team will be able to get around to this in the near future and decide whether we'd like to include this or not

@snuk182
Copy link
Author

snuk182 commented Nov 13, 2018

No worries. As long as it hangs around and is mergeable, I don't mind.
If someone has a time and will to make a review and suggest a change or extra test case, I'll appreciate that a lot.

@bors
Copy link
Contributor

bors commented Nov 21, 2018

☔ The latest upstream changes (presumably #6336) made this pull request unmergeable. Please resolve the merge conflicts.

# Conflicts:
#	src/cargo/core/compiler/build_context/mod.rs
#	src/cargo/core/compiler/context/unit_dependencies.rs
#	src/cargo/core/dependency.rs
#	src/cargo/core/package.rs
#	src/cargo/core/resolver/context.rs
#	src/cargo/core/resolver/mod.rs
#	src/cargo/core/resolver/resolve.rs
#	src/cargo/core/summary.rs
#	src/cargo/ops/cargo_output_metadata.rs
#	src/cargo/util/toml/mod.rs
@snuk182
Copy link
Author

snuk182 commented Dec 10, 2018

Patch updated to match the current master.

@bors
Copy link
Contributor

bors commented Dec 11, 2018

☔ The latest upstream changes (presumably #6416) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Contributor

bors commented Dec 13, 2018

☔ The latest upstream changes (presumably #6425) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Contributor

bors commented Feb 20, 2019

☔ The latest upstream changes (presumably #6687) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Contributor

bors commented Mar 6, 2019

☔ The latest upstream changes (presumably #6653) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Contributor

bors commented Apr 13, 2019

☔ The latest upstream changes (presumably #6842) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added the S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. label Apr 13, 2019
@alexcrichton
Copy link
Member

I think this has become somewhat bitrotted over time and stale, so I'm going to close this. If you'd like to resubmit it though with a rebase plase feel free to do so!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants