Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn/err on some unused manifest keys in workspaces. #6276

Merged
merged 1 commit into from
Nov 7, 2018
Merged

Warn/err on some unused manifest keys in workspaces. #6276

merged 1 commit into from
Nov 7, 2018

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Nov 7, 2018

  • Err on dependencies, features, target, badges in virtual root.
  • Warn on replace/patch in members.

Closes #6248, Closes #4870, Closes #4947

@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@ehuss
Copy link
Contributor Author

ehuss commented Nov 7, 2018

@alexcrichton I'm curious if it was intentional to not reject [dependencies]. This dates back to the original PR that added workspaces, and it seems conspicuously absent.

@alexcrichton
Copy link
Member

@bors: r+

Thanks for this! I think not rejecting [dependencies] was probably just an oversight, I should have been more thorough back then!

@bors
Copy link
Collaborator

bors commented Nov 7, 2018

📌 Commit 5b2b5f9 has been approved by alexcrichton

@bors
Copy link
Collaborator

bors commented Nov 7, 2018

⌛ Testing commit 5b2b5f9 with merge 237f86e...

bors added a commit that referenced this pull request Nov 7, 2018
@bors
Auto merge of #6276 - ehuss:ws-unused, r=alexcrichton
237f86e 
Warn/err on some unused manifest keys in workspaces.

- Err on dependencies, features, target, badges in virtual root.
- Warn on replace/patch in members.

Closes #6248, Closes #4870, Closes #4947
@bors
Copy link
Collaborator

bors commented Nov 7, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 237f86e to master...

@bors bors merged commit 5b2b5f9 into rust-lang:master Nov 7, 2018
@ehuss ehuss mentioned this pull request Jan 11, 2019
Closed
@ehuss ehuss added this to the 1.32.0 milestone Feb 6, 2022
@weihanglo weihanglo mentioned this pull request Oct 14, 2023
Closed
@weihanglo weihanglo mentioned this pull request Dec 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
None yet
Projects
None yet
Milestone
1.32.0
4 participants
@ehuss @rust-highfive @alexcrichton @bors