Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed RUST_LOG usage to CARGO_LOG to avoid confusion. #6190

Closed
wants to merge 2 commits into from

Conversation

zachlute
Copy link
Contributor

Fixes #6189.

Changes Cargo to to initialize env_logger with the CARGO_LOG variable instead of RUST_LOG. Also updated documentation, tests, etc. to match the change.

@rust-highfive
Copy link

r? @matklad

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

Thanks for the PR! In light of https://internals.rust-lang.org/t/cargo-and-rustup-development/8615/1 I don't think we're willing to merge this at this time. This is changing a very longstanding interface in Cargo which I unfortunately think we don't have ti,e to prioritize and review until after the edition and planning.

@zachlute
Copy link
Contributor Author

Yeah, no worries. It was a small change (from an input-work perspective) and I don't think it's high priority or anything that would warrant taking time away from larger issues right now.

@alexcrichton
Copy link
Member

Ok sure thing, would you be ok closing this in the meantime?

@zachlute
Copy link
Contributor Author

Yeah, there's still the issue to track the request so no reason this has to sit around taking up space.

@zachlute zachlute closed this Oct 20, 2018
@Eh2406
Copy link
Contributor

Eh2406 commented Oct 21, 2018

@alexcrichton I see why this should not be merged during the features-freeze, but I am strongly in favor of this change in general.

@zachlute
Copy link
Contributor Author

Reopening this now that we're past the feature freeze that prevented serious discussion initially.

@zachlute
Copy link
Contributor Author

Ugh, I merged instead of rebased this because I'm a moron and forget how to git. I'll clean up the mess and probably just open another PR. Ignore me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cargo should use a variable other than RUST_LOG for env_logger.
5 participants