Setup Stale Probot #6020

dwijnand · 2018-09-13T00:38:53Z

alexcrichton · 2018-09-13T01:24:14Z

Nice, that was easy! Do you know if the docs say anything about rate limiting? Ideally we'd just receive at most 5 stale notifications a day (or something like that). I'm not sure if we'd want to get hundreds of notifications here all at once :(

Additionally, could the default threshold for being stale be lifted? I think something like 180 days should probably be a good cushion to start with (although a year may be more conservative).

For wording, I like what you've got! Perhaps tweak it a bit like so?

As there hasn't been any recent activity here for $NN days this has been marked as stale, and if no further activity happens for $YY days this will be automatically closed. This is an automatic action and may be in error, if this issue should remain open please comment to that effect!

When commenting, we'd be eternally grateful if some details such as these could be included:

Is this still relevant?

If so, what is blocking it?

Is it known what could be done to help move this forward?

Thank you for contributing!

If you're reading this comment from the distant future, fear not if this issue was closed automatically. If you believe it's still an issue please leave a comment and a team member can reopen this issue. Opening a new issue is also acceptable!

I also really like how we can have labels for "never stale" issues! We may want to remove E-easy and E-help-wanted from that list though because if it's been stale for so long it likely isn't easy or doesn't have good enough mentoring instructions! I'd also remove I-nominated from the list because if we haven't gotten to removing the nominated tag in such a long time we definitely should! (probably same with P-high, if it's been stale for so long as P-high it may not actually be high priority)

I think C-tracking-issue is good to leave as "never stale" along with "Feature accepted". I wonder if we should perhaps conservatively say that feature requests are never stale? On one hand that may be one of the big pain points of closing issues, but on the other hand it's also good to clear these out as they're often fixed by other PRs that happen after the issue was initially open. Curious to hear what you think!

alexcrichton · 2018-09-13T01:29:12Z

Ah it looks like the README also has more configuration options documented. Perhaps we could add:

staleLabel: stale
closeComment: >
  A comment to confirm that this is being closed due to being stale and the previous comment should have more information
limitPerRun: 1
only: issues

The limitPerRun seems like our best rate limiting source. 24/day is still a bit high but we could see how it goes perhaps?

Makes sense to let these be closed as it's likely they aren't easy or don't have good enough mentoring instructions.

If they haven't had any activity (or been solved) in long enough, they're probably just as stale as every other issue.

dwijnand · 2018-09-13T02:02:39Z

Great suggestions.

I went with 180 days, over a year, though I'm not against a year.

The idea to include feature requests is an interesting one. It's our biggest label, at 237/735 issues currently. Aleksey also specifically called it out in the contributing guide ("C-feature-request marks proposals for new features"). So I don't know what the best choice is. Maybe start exempting them and then when we get more comfortable with the idea of stale bot remove the exemption?

Do you feel strongly about restricting stale bot to just issues? Personally I feel that the pull request queue even more than the issue backlog shouldn't be left to go stale.

dwijnand · 2018-09-13T06:15:30Z

Personally I feel that the pull request queue even more than the issue backlog shouldn't be left to go stale.

.. and we might want a shorter daysUntilStale for pull requests.

Eh2406

@rust-highfive sometimes uses "I" messages, So I experimented with that form hear. What do you think?

Eh2406 · 2018-09-13T15:00:03Z

.github/stale.yml

+
+markComment: >
+  As there hasn't been any recent activity here for 180 days this has been
+  marked as stale, and if no further activity happens for 7 days this will be


I see that there has not been any activity in over 180 days, can I close this issue?

If the"I" is being overused then maybe:

Move to close? As there has not been activity in over 180 days. If there is no response in 7 days this will be closed for now. The teem would appreciate if anyone could give an update on:

Eh2406 · 2018-09-13T15:00:37Z

.github/stale.yml

+  As there hasn't been any recent activity here for 180 days this has been
+  marked as stale, and if no further activity happens for 7 days this will be
+  automatically closed. This is an automatic action and may be in error, if this
+  issue should remain open please comment to that effect!


I am just a bot, so if this should stay open leave a comment.

Eh2406 · 2018-09-13T15:01:46Z

.github/stale.yml

+  issue should remain open please comment to that effect!
+
+  When commenting, we'd be eternally grateful if some details such as these
+  could be included:


The teem would appreciate if anyone could give an update on:

Eh2406 · 2018-09-13T15:02:38Z

.github/stale.yml

+  acceptable!
+
+closeComment: >
+  A comment to confirm that this is being closed due to being stale and the


I am going to close this for now as I did not see an update. If it's still an issue, I am sorry. Please leave a comment and a team member can reopen it, or open a new issue to start a new discussion of the problem.

Eh2406 · 2018-09-13T15:02:56Z

.github/stale.yml

+  If you're reading this comment from the distant future, fear not if this issue
+  was closed automatically. If you believe it's still an issue please leave a
+  comment and a team member can reopen this issue. Opening a new issue is also
+  acceptable!


If I don't see new activity in the next 7 days I will close this for now.

alexcrichton · 2018-09-13T18:56:14Z

@dwijnand

Maybe start exempting them and then when we get more comfortable with the idea of stale bot remove the exemption?

Sounds like a good idea to me!

Do you feel strongly about restricting stale bot to just issues?

PRs are sort of interesting in the sense that if it's blocked on us (cargo reviewers) then we should never close the PR. If the PR is blocked on the author, though, it makes sense to auto-close after awhile. I think we can try this out though, the repo is relatively low-traffic in the sense that we as authors can hold ourselves accountable for responding to stale PRs.

So yes, let's enable PRs!

alexcrichton · 2018-09-13T22:21:46Z

Looking good to me!

@Eh2406's suggestions sound great to me, and after that I think we might be ready to kick the tires

dwijnand · 2018-09-14T14:56:33Z

/cc @wycats, happy with wording, at least to start with?

joshtriplett · 2018-09-14T17:56:01Z

Looks great to me! Thanks for the updates.

alexcrichton · 2018-09-14T20:42:35Z

@bors: r+

Alright let's try this!

bors · 2018-09-14T20:42:36Z

📌 Commit 53d10c8 has been approved by alexcrichton

bors · 2018-09-14T22:15:56Z

⌛ Testing commit 53d10c8 with merge 3fc546c...

@alexcrichton

Setup Stale Probot r? @alexcrichton /cc @Eh2406

bors · 2018-09-14T23:32:05Z

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 3fc546c to master...

alexcrichton · 2018-09-15T01:00:49Z

@dwijnand ok the next step is to install the app? Is that all that's needed?

dwijnand · 2018-09-15T07:46:19Z

@alexcrichton I believe so!

alexcrichton · 2018-09-15T15:54:41Z

Ok! It's now installed, so let's see how it goes...

Setup Stale Probot

078c353

rust-highfive assigned alexcrichton Sep 13, 2018

dwijnand added 7 commits September 13, 2018 02:38

Limit to 1 stale bot action per hour (24 per day)

4bd6a7d

Raise threshold to 180 days until issues are stale (6 months)

0b2adb0

Tweak stale bots initial comment wording

d07ae57

E-easy/E-help-wanted issues can go stale

bedff50

Makes sense to let these be closed as it's likely they aren't easy or don't have good enough mentoring instructions.

I-nominated/P-high issues can go stale

04cd489

If they haven't had any activity (or been solved) in long enough, they're probably just as stale as every other issue.

Configure a close comment message for stale bot

5f8f125

Restrict stale bot to just issues

7eb2288

Eh2406 reviewed Sep 13, 2018

View reviewed changes

dwijnand added 2 commits September 13, 2018 20:43

Keep C-feature-request from going stale

df5737d

Allow PRs to be marked stale & be closed

80986d4

Try using an active voice in the stale bot messages

6cbc5c9

dwijnand added 2 commits September 14, 2018 15:57

Spelling

12579f6

Often it's not the issue author that needs to comment

53d10c8

bors added a commit that referenced this pull request Sep 14, 2018

Auto merge of #6020 - dwijnand:stale-bot, r=alexcrichton

3fc546c

Setup Stale Probot r? @alexcrichton /cc @Eh2406

bors merged commit 53d10c8 into rust-lang:master Sep 14, 2018

dwijnand deleted the stale-bot branch September 15, 2018 07:45

dwijnand mentioned this pull request Sep 16, 2018

Tracking Issue for Stale Bot #6035

Closed

ehuss added this to the 1.31.0 milestone Feb 6, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Setup Stale Probot #6020

Setup Stale Probot #6020

dwijnand commented Sep 13, 2018

alexcrichton commented Sep 13, 2018

alexcrichton commented Sep 13, 2018

dwijnand commented Sep 13, 2018

dwijnand commented Sep 13, 2018

Eh2406 left a comment

Eh2406 Sep 13, 2018

Eh2406 Sep 13, 2018

Eh2406 Sep 13, 2018

Eh2406 Sep 13, 2018

Eh2406 Sep 13, 2018

Eh2406 Sep 13, 2018

alexcrichton commented Sep 13, 2018

alexcrichton commented Sep 13, 2018

dwijnand commented Sep 14, 2018

joshtriplett commented Sep 14, 2018

alexcrichton commented Sep 14, 2018

bors commented Sep 14, 2018

bors commented Sep 14, 2018

bors commented Sep 14, 2018

alexcrichton commented Sep 15, 2018

dwijnand commented Sep 15, 2018

alexcrichton commented Sep 15, 2018

Setup Stale Probot #6020

Setup Stale Probot #6020

Conversation

dwijnand commented Sep 13, 2018

alexcrichton commented Sep 13, 2018

alexcrichton commented Sep 13, 2018

dwijnand commented Sep 13, 2018

dwijnand commented Sep 13, 2018

Eh2406 left a comment

Choose a reason for hiding this comment

Eh2406 Sep 13, 2018

Choose a reason for hiding this comment

Eh2406 Sep 13, 2018

Choose a reason for hiding this comment

Eh2406 Sep 13, 2018

Choose a reason for hiding this comment

Eh2406 Sep 13, 2018

Choose a reason for hiding this comment

Eh2406 Sep 13, 2018

Choose a reason for hiding this comment

Eh2406 Sep 13, 2018

Choose a reason for hiding this comment

alexcrichton commented Sep 13, 2018

alexcrichton commented Sep 13, 2018

dwijnand commented Sep 14, 2018

joshtriplett commented Sep 14, 2018

alexcrichton commented Sep 14, 2018

bors commented Sep 14, 2018

bors commented Sep 14, 2018

bors commented Sep 14, 2018

alexcrichton commented Sep 15, 2018

dwijnand commented Sep 15, 2018

alexcrichton commented Sep 15, 2018