Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix serialization bug in edition field of TomlProject. #5908

Merged
merged 1 commit into from
Aug 19, 2018
Merged

Fix serialization bug in edition field of TomlProject. #5908

merged 1 commit into from
Aug 19, 2018

Conversation

orium
Copy link
Member

@orium orium commented Aug 18, 2018

Fixes #5906.

@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@orium orium changed the title Fix serialization bug edition field of TomlProject. Fix serialization bug in edition field of TomlProject. Aug 18, 2018
@alexcrichton
Copy link
Member

@bors: r+

@orium
Copy link
Member Author

orium commented Aug 19, 2018

@alexcrichton, I think @bors was taking a nap and didn't hear you :)

@alexcrichton
Copy link
Member

@bors: r+

True!

@bors
Copy link
Collaborator

bors commented Aug 19, 2018

📌 Commit 8590a5f has been approved by alexcrichton

@bors
Copy link
Collaborator

bors commented Aug 19, 2018

⌛ Testing commit 8590a5f with merge cc88d01...

bors added a commit that referenced this pull request Aug 19, 2018
Fix serialization bug in `edition` field of `TomlProject`.

Fixes #5906.
@bors
Copy link
Collaborator

bors commented Aug 19, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing cc88d01 to master...

@bors bors merged commit 8590a5f into rust-lang:master Aug 19, 2018
@orium orium deleted the fix-package-cargo-toml branch October 9, 2019 22:54
@ehuss ehuss added this to the 1.30.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cargo package does not always work if used with 2018 edition
5 participants