Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

now that we respect gitignore tests can be simplified #5810

Merged
merged 2 commits into from
Jul 27, 2018

Conversation

Eh2406
Copy link
Contributor

@Eh2406 Eh2406 commented Jul 26, 2018

There are a lot of test that used a tempfile to avoid the fact that cargo would not init a git in the test folder. (or because they were copy/pasted from one that did.) Now that #5733 landed we can remove them all.

@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

@bors: r+

Nice!

@bors
Copy link
Contributor

bors commented Jul 26, 2018

📌 Commit 7fc0dff has been approved by alexcrichton

@dwijnand
Copy link
Member

Sweet, more test simplification 👍

@bors
Copy link
Contributor

bors commented Jul 26, 2018

⌛ Testing commit 7fc0dff with merge 3b14105...

bors added a commit that referenced this pull request Jul 26, 2018
now that we respect gitignore tests can be simplified

There are a lot of test that used a tempfile to avoid the fact that cargo would not init a git in the test folder. (or because they were copy/pasted from one that did.) Now that #5733 landed we can remove them all.
@Eh2406
Copy link
Contributor Author

Eh2406 commented Jul 26, 2018

BTW I love your stats on the contributors graphs so far:

dwijnand
86 commits 7,236 ++ 13,923 --

I love that you have net removed code! :-P

@dwijnand
Copy link
Member

Yep. I like to sum up my contributions as "net negative" 😉

@bors
Copy link
Contributor

bors commented Jul 26, 2018

💥 Test timed out

@alexcrichton
Copy link
Member

@bors: retry

@Eh2406
Copy link
Contributor Author

Eh2406 commented Jul 27, 2018

@bors: are you still alive?

@alexcrichton
Copy link
Member

@bors: retry

@Eh2406
Copy link
Contributor Author

Eh2406 commented Jul 27, 2018

@bors are you still there?

@bors
Copy link
Contributor

bors commented Jul 27, 2018

🍰 Target acquired

@Eh2406
Copy link
Contributor Author

Eh2406 commented Jul 27, 2018

@bors: r=alexcrichton

@bors
Copy link
Contributor

bors commented Jul 27, 2018

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Jul 27, 2018

📌 Commit 7fc0dff has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Jul 27, 2018

⌛ Testing commit 7fc0dff with merge 03e8934...

bors added a commit that referenced this pull request Jul 27, 2018
now that we respect gitignore tests can be simplified

There are a lot of test that used a tempfile to avoid the fact that cargo would not init a git in the test folder. (or because they were copy/pasted from one that did.) Now that #5733 landed we can remove them all.
@bors
Copy link
Contributor

bors commented Jul 27, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 03e8934 to master...

@bors bors merged commit 7fc0dff into rust-lang:master Jul 27, 2018
@Eh2406 Eh2406 deleted the test-fix branch July 27, 2018 17:41
@ehuss ehuss added this to the 1.29.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants