Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a -Z no-index-update for crater and benchmarking #4990

Merged
merged 2 commits into from
Jan 31, 2018

Conversation

Eh2406
Copy link
Contributor

@Eh2406 Eh2406 commented Jan 31, 2018

This is a fix for #3479

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

Thanks! Could you be sure to add a test for this as well?

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Collaborator

bors commented Jan 31, 2018

📌 Commit ba05437 has been approved by alexcrichton

@bors
Copy link
Collaborator

bors commented Jan 31, 2018

⌛ Testing commit ba05437 with merge df11070...

bors added a commit that referenced this pull request Jan 31, 2018
add a -Z no-index-update for crater and benchmarking

This is a fix for #3479
@bors
Copy link
Collaborator

bors commented Jan 31, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing df11070 to master...

@bors bors merged commit ba05437 into rust-lang:master Jan 31, 2018
@Eh2406 Eh2406 deleted the Zno-index-update branch February 1, 2018 03:40
@ehuss ehuss added this to the 1.25.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants