Rename main thread from '<main>' to 'main'. #2747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request resolves the test failure in rust pull request 33803
|
r? @wycats (rust_highfive has picked a reviewer for you, use r? to override) |
|
Unfortunately this won't be able to land as this doesn't work on stable rust, perhaps the assertions could be relaxed by using a |
|
Right. Let me fix that first. |
|
Hmm, it fails to build on Linux. Anything I can do here? |
|
@bors: r+ Nah it's just something I need to investigate soon, thanks! |
|
📌 Commit 6a2e613 has been approved by |
bors
added a commit
that referenced
this pull request
May 31, 2016
Rename main thread from '<main>' to 'main'. This pull request resolves the test failure in rust pull request 33803 rust-lang/rust#33803
|
☀️ Test successful - cargo-cross-linux, cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves the test failure in rust pull request 33803
rust-lang/rust#33803