metadata: change resolve serialization #2331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .unwrap_or(Vec::new()), | ||
| } | ||
| }) | ||
| .collect(), |
There was a problem hiding this comment.
Stylistically this tends to look moreso like:
nodes: resolve.iter().map(|id| {
Node {
foo: ...
}
}).collect()(helps cut down on the indentation
There was a problem hiding this comment.
Yep, rustfmt tends to drift rightwards :(
matklad
force-pushed
the
metadata-encodable-resolve
branch
from
04fb2cf to
8456d2a
Compare
|
rebased |
bors
added a commit
that referenced
this pull request
Jan 29, 2016
|
I've added support for this format to intellij-rust: https://github.com/intellij-rust/intellij-rust/pull/225/files. It seems to work, so hopefully there is no more outstanding issues here ;) |
|
Nice! |
|
☀️ Test successful - cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.