Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Probe $CARGO_HOME/bin for subcommands by default #2192

Merged
merged 1 commit into from
Dec 4, 2015

Conversation

alexcrichton
Copy link
Member

Don't require PATH modifications for new cargo subcommands by looking
specifically in $CARGO_HOME/bin for installed commands.

Closes #2189

@rust-highfive
Copy link

r? @huonw

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member Author

r? @brson

@rust-highfive rust-highfive assigned brson and unassigned huonw Dec 3, 2015
@brson
Copy link
Contributor

brson commented Dec 3, 2015

@bors r+ Thanks for adding this.

@bors
Copy link
Collaborator

bors commented Dec 3, 2015

📌 Commit 48b3c78 has been approved by brson

@bors
Copy link
Collaborator

bors commented Dec 3, 2015

⌛ Testing commit 48b3c78 with merge 252c4f1...

@bors
Copy link
Collaborator

bors commented Dec 3, 2015

💔 Test failed - cargo-mac-32

@alexcrichton
Copy link
Member Author

@bors: retry

On Thu, Dec 3, 2015 at 3:56 PM, bors [email protected] wrote:

[image: 💔] Test failed - cargo-mac-32
http://buildbot.rust-lang.org/builders/cargo-mac-32/builds/1396


Reply to this email directly or view it on GitHub
#2192 (comment).

@bors
Copy link
Collaborator

bors commented Dec 4, 2015

⌛ Testing commit 48b3c78 with merge 7dac07c...

@bors
Copy link
Collaborator

bors commented Dec 4, 2015

💔 Test failed - cargo-mac-64

Don't require PATH modifications for new cargo subcommands by looking
specifically in $CARGO_HOME/bin for installed commands.

Closes rust-lang#2189
@alexcrichton
Copy link
Member Author

@bors: r=brson 20b768e

@bors
Copy link
Collaborator

bors commented Dec 4, 2015

⌛ Testing commit 20b768e with merge 488e8d8...

bors added a commit that referenced this pull request Dec 4, 2015
Don't require PATH modifications for new cargo subcommands by looking
specifically in $CARGO_HOME/bin for installed commands.

Closes #2189
@bors
Copy link
Collaborator

bors commented Dec 4, 2015

@bors bors merged commit 20b768e into rust-lang:master Dec 4, 2015
This was referenced Dec 4, 2015
@alexcrichton alexcrichton deleted the search-cargo-home branch December 4, 2015 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants