Use gcc crate in native build script example #1760
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @huonw (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
| @@ -350,16 +350,16 @@ portable, and standardized. For example, the build script could be written as: | |||
| ```rust,ignore | |||
| // build.rs | |||
|
|
|||
| // Bring in a dependency on an externally maintained `cc` package which manages | |||
| // Bring in a dependency on an externally maintained `gcc` package which manages | |||
| // invoking the C compiler. | |||
| extern crate cc; | |||
There was a problem hiding this comment.
I think this'll need to be gcc
|
Fixed the executable bit + squashed. |
|
|
||
| ```toml | ||
| [build-dependencies] | ||
| gcc = "*" |
There was a problem hiding this comment.
Could you switch to 0.3 instead of *? Other than that looks good to me!
|
☀️ Test successful - cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-64 |
No description provided.