Skip to content

fix(git): Make PR dep note cloer to our style guide #17436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rustbot merged 1 commit into from
Sep 3, 2026
+9 −12
Merged

fix(git): Make PR dep note cloer to our style guide #17436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/sources/git/utils.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1873,10 +1873,9 @@ pub(crate) fn note_github_pull_request(url: &str) -> Option<String> {
let rev = format!("refs/pull/{pr_number}/head");
return Some(format!(
concat!(
"\n\nnote: GitHub url {} is not a repository. \n",
"help: Replace the dependency with \n",
" `git = \"{}\" rev = \"{}\"` \n",
" to specify pull requests as dependencies' revision."
"\n\nnote: GitHub url {} is not a repository\n",
"help: to specify a pull request as a dependency, replace the dependency with:\n",
" `git = \"{}\" rev = \"{}\"`",
),
url, repo_url, rev
));
Expand Down
7 changes: 3 additions & 4 deletions tests/testsuite/bad_config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2368,10 +2368,9 @@ Caused by:
Caused by:
unable to update https://github.com/rust-lang/does-not-exist/pull/123
...
[NOTE] GitHub url https://github.com/rust-lang/does-not-exist/pull/123 is not a repository.
[HELP] Replace the dependency with
`git = "https://github.com/rust-lang/does-not-exist.git" rev = "refs/pull/123/head"`
to specify pull requests as dependencies' revision.
[NOTE] GitHub url https://github.com/rust-lang/does-not-exist/pull/123 is not a repository
[HELP] to specify a pull request as a dependency, replace the dependency with:
`git = "https://github.com/rust-lang/does-not-exist.git" rev = "refs/pull/123/head"`
...
"#]])
.run();
Expand Down
7 changes: 3 additions & 4 deletions tests/testsuite/patch.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,10 +411,9 @@ Caused by:
if a proxy or similar is necessary `net.git-fetch-with-cli` may help here
https://doc.rust-lang.org/cargo/reference/config.html#netgit-fetch-with-cli

[NOTE] GitHub url https://github.com/rust-lang/does-not-exist/pull/123 is not a repository.
[HELP] Replace the dependency with
`git = "https://github.com/rust-lang/does-not-exist.git" rev = "refs/pull/123/head"`
to specify pull requests as dependencies' revision.
[NOTE] GitHub url https://github.com/rust-lang/does-not-exist/pull/123 is not a repository
[HELP] to specify a pull request as a dependency, replace the dependency with:
`git = "https://github.com/rust-lang/does-not-exist.git" rev = "refs/pull/123/head"`

Caused by:
...
Expand Down
Loading