Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. We actually had a similar PR (#17294) recently and got closed because it was a full bot automation not addressing reviewers' question correctly.
This seems to be a fairly pure refactor. Is there any reason it is still behind draft?
View changes since the review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am also interested in how you fount this, if you don't mind sharing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, sorry, took it out of draft!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tend to use Ultra mode to do exploration of projects and find interesting optimization opportunities, then will go deep on a few of them (try out a prototype, do some benchmarking, etc.). In this case I actually asked it to find opportunities "similar in spirit" to xmakro's Clippy optimizations which I found neat. It's a very different project though with very different bottlenecks so most of the surfaced findings were not that similar in spirit. I'm happy to share the full output if you want to see it (though it is of course LLM-generated).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds like a fun exploration!
We have a Performance label tracking those. One of the most possible area to improve is asyncifying Cargo. Cargo has its bespoke concurrency control before async/await. For example, dependency source update and manifest parsing are still serial. In #t-cargo > Parallelizing parts of cargo @Kobzol did an experiment on that but not yet ready.
Anyway, if you have found something interesting, feel free to open issues!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rust project may have an LLM policy soonish I guess, thoughif people bring a tidy-up doc and discuss with me as a human, personally I don't mind it is LLM-assisted or not.