Remove unnecessary return at end of functions

[gkamathe]

What does this PR try to resolve?

Remove unnecessary return keyword at the end of two functions where the expression form Ok(()) is idiomatic Rust style.

How to test and review this PR?

It is a stylistic change — return Ok(()) and Ok(()) are semantically identical at the end of a function. Existing tests pass unchanged.

[rustbot]

r? @epage

rustbot has assigned @epage.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

• Owners of files modified in this PR: @epage, @weihanglo
• @epage, @weihanglo expanded to epage, weihanglo
• Random selection from epage, weihanglo

[weihanglo]

Looks reasonable.

Just curious, were you looking at these with your bare eyes, or with helps of some tools. I meant, maybe clippy has some lints automating these so people don't need to edit them manually. That said, we have only enabled a strict subset of lints in Cargo.

cargo/Cargo.toml

Lines 131 to 145 in ef229e4

	[workspace.lints.rust]
	rust_2018_idioms = "warn" # TODO: could this be removed?
	[workspace.lints.rustdoc]
	private_intra_doc_links = "allow"
	[workspace.lints.clippy]
	all = { level = "allow", priority = -2 }
	correctness = { level = "warn", priority = -1 }
	dbg_macro = "warn"
	disallowed_methods = "warn"
	disallowed_types = "warn"
	print_stderr = "warn"
	print_stdout = "warn"
	self_named_module_files = "warn"

View changes since this review

[gkamathe]

Thanks @weihanglo

Just curious, were you looking at these with your bare eyes, or with helps of some tools.

A mix really, no set method

I meant, maybe clippy has some lints automating these so people don't need to edit them manually.

There is a needless_return lint available via clippy below

https://rust-lang.github.io/rust-clippy/master/index.html#needless_return