Skip to content

fix(diag): Give diagnostics the same display path behavior as rustc - #17101

Merged
weihanglo merged 1 commit into
rust-lang:masterfrom
epage:path
Jun 14, 2026
Merged

fix(diag): Give diagnostics the same display path behavior as rustc#17101
weihanglo merged 1 commit into
rust-lang:masterfrom
epage:path

Conversation

@epage

@epage epage commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

What does this PR try to resolve?

Part of #12235

How to test and review this PR?

@rustbot rustbot added A-manifest Area: Cargo.toml issues A-workspaces Area: workspaces S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 14, 2026
@rustbot

rustbot commented Jun 14, 2026

Copy link
Copy Markdown
Collaborator

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @ehuss, @epage, @weihanglo
  • @ehuss, @epage, @weihanglo expanded to ehuss, epage, weihanglo
  • Random selection from ehuss, weihanglo

@epage epage mentioned this pull request Jun 14, 2026
20 tasks
[PACKAGED] 8 files, [FILE_SIZE]B ([FILE_SIZE]B compressed)
[VERIFYING] bar v1.2.3 ([ROOT]/foo/bar)
[WARNING] ../target/package/bar-1.2.3/Cargo.toml: only one of `license` or `license-file` is necessary
[WARNING] Cargo.toml: only one of `license` or `license-file` is necessary

@weihanglo weihanglo Jun 14, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not ideal but pre-existing :(

View changes since the review

@weihanglo
weihanglo added this pull request to the merge queue Jun 14, 2026
Merged via the queue into rust-lang:master with commit 4ba81eb Jun 14, 2026
29 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 14, 2026
@epage
epage deleted the path branch June 16, 2026 14:01
rust-bors Bot pushed a commit to rust-lang/rust that referenced this pull request Jun 17, 2026
Update cargo submodule

7 commits in fe63976b245b8a649c3f2949bf89fdc307bfbae4..598ab48ec328e3e4f5e4e373d8df7264bc8e27cd
2026-06-11 09:17:57 +0000 to 2026-06-17 02:39:50 +0000
- Improved the test error messages when 'rustc -V' fails (rust-lang/cargo#17108)
- test(install): `cargo install` --path honors MSRV (rust-lang/cargo#17102)
- feat(trim-paths): emit `CARGO_TRIM_PATHS_REMAP` for build.rs (rust-lang/cargo#17104)
- Add funding links (rust-lang/cargo#17103)
- fix(diag): Give diagnostics the same display path behavior as rustc (rust-lang/cargo#17101)
- refactor: remove cargo-util-terminal from bump-check exclusions (rust-lang/cargo#17098)
- fix(diag): Report all errors, in order (rust-lang/cargo#17095)
@rustbot rustbot added this to the 1.98.0 milestone Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-manifest Area: Cargo.toml issues A-workspaces Area: workspaces

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants