Skip to content

refactor(diag): Simplify adding of new diagnostics #17015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
epage merged 17 commits into from
May 20, 2026
Merged

refactor(diag): Simplify adding of new diagnostics #17015

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
1100efa
fix(diag): Require -Zcargo-lints for mostly-unused lint
epage May 19, 2026
cffda16
refactor(diag): Make workspace parse pass data driven
epage May 19, 2026
ccdf7e2
refactor(diag): Make package lints have a consistent parameter list
epage May 19, 2026
48a3e90
refactor(diag): Make package parse pass data driven
epage May 19, 2026
1857c84
refAactor(diag): Move the PARSE_PASS_RULES
epage May 19, 2026
66d0140
refactor(diag): Put the caller in charge of parse pass rules
epage May 19, 2026
52967af
refactor(diag): Reduce lint visibility to catch uncalled rules
epage May 19, 2026
3340db3
refactor(diag): Make rule fn names consistent
epage May 19, 2026
c48f494
refactor(diag): Pull in manifest like we do else where
epage May 19, 2026
a90293f
refactor(diag): Correctly classify missing_lints_features as a diagno…
epage May 19, 2026
b593911
refactor(diag): Pull out a struct for result of level calculation
epage May 19, 2026
2ba30de
refactor(diag): Pull out ManifestFor creation
epage May 19, 2026
1fa836a
refactor(diag): Make it easy to access items in tests
epage May 19, 2026
c7afb71
refactor(diag): Associate lint definition with rule
epage May 19, 2026
8a2a538
refactor(diag): Split unknown_lints into layers
epage May 19, 2026
af45185
refactor(diag): Freshly get lints for unknown_lints
epage May 19, 2026
c2684c1
refactor(diag): Pull lint level calculation into pass
epage May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions src/cargo/diagnostics/passes.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,12 +227,6 @@ fn emit_parse_ws_diagnostics(workspace: &Workspace<'_>) -> CargoResult<()> {
&mut stats,
workspace.gctx(),
)?;
}

// This is a short term hack to allow `blanket_hint_mostly_unused`
// to run without requiring `-Zcargo-lints`, which should hopefully
// improve the testing experience while we are collecting feedback
if workspace.gctx().cli_unstable().profile_hint_mostly_unused {
Comment on lines -232 to -235

@Muscraft Muscraft May 20, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshtriplett, just wanted to make you aware of this change

View changes since the review

blanket_hint_mostly_unused(
workspace,
workspace.root_maybe(),
Expand Down
8 changes: 4 additions & 4 deletions tests/testsuite/lints/blanket_hint_mostly_unused.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ hint-mostly-unused = true
)
.file("src/main.rs", "fn main() {}")
.build();
p.cargo("check -Zprofile-hint-mostly-unused -v")
p.cargo("check -Zprofile-hint-mostly-unused -Zcargo-lints -Zcargo-lints -v")
.masquerade_as_nightly_cargo(&["profile-hint-mostly-unused", "cargo-lints"])
.with_stderr_data(str![[r#"
[WARNING] `hint-mostly-unused` is being blanket applied to all dependencies
Expand Down Expand Up @@ -61,7 +61,7 @@ hint-mostly-unused = true
)
.file("src/main.rs", "fn main() {}")
.build();
p.cargo("check -Zprofile-hint-mostly-unused -v")
p.cargo("check -Zprofile-hint-mostly-unused -Zcargo-lints -v")
.masquerade_as_nightly_cargo(&["profile-hint-mostly-unused", "cargo-lints"])
.with_stderr_data(str![[r#"
[WARNING] `hint-mostly-unused` is being blanket applied to all dependencies
Expand Down Expand Up @@ -100,7 +100,7 @@ hint-mostly-unused = true
)
.file("src/main.rs", "fn main() {}")
.build();
p.cargo("check -Zprofile-hint-mostly-unused -v")
p.cargo("check -Zprofile-hint-mostly-unused -Zcargo-lints -v")
.masquerade_as_nightly_cargo(&["profile-hint-mostly-unused", "cargo-lints"])
.with_stderr_data(str![[r#"
[WARNING] `hint-mostly-unused` is being blanket applied to all dependencies
Expand Down Expand Up @@ -148,7 +148,7 @@ authors = []
.file("foo/src/lib.rs", "")
.build();

p.cargo("check -Zprofile-hint-mostly-unused -v")
p.cargo("check -Zprofile-hint-mostly-unused -Zcargo-lints -v")
.masquerade_as_nightly_cargo(&["profile-hint-mostly-unused", "cargo-lints"])
.with_stderr_data(str![[r#"
[WARNING] `hint-mostly-unused` is being blanket applied to all dependencies
Expand Down