Skip to content

fix(test): strip RUSTUP_TOOLCHAIN_SOURCE from test environment #16857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weihanglo merged 1 commit into from
Apr 8, 2026
+1 −0
Merged

fix(test): strip RUSTUP_TOOLCHAIN_SOURCE from test environment #16857

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions crates/cargo-test-support/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1458,6 +1458,7 @@ pub trait TestEnvCommandExt: Sized {
.env_remove("RUSTDOC")
.env_remove("RUSTDOCFLAGS")
.env_remove("RUSTFLAGS")
.env_remove("RUSTUP_TOOLCHAIN_SOURCE")
Copy link
Copy Markdown
Member

@weihanglo weihanglo Apr 8, 2026 •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

View changes since the review

Removing this separately seems fine for cargo devs that has a directory override, though I am not sure if we want to wait for #16469 or not.

Copy link
Copy Markdown
Member Author

@Muscraft Muscraft Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure either. If this truly doesn't affect anything else, it would be nice to have it in sooner to make running tests less cumbersome, but at the same time, I don't want to make #16469 harder.

.env_remove("SSH_AUTH_SOCK") // ensure an outer agent is never contacted
.env_remove("USER") // not set on some rust-lang docker images
.env_remove("XDG_CONFIG_HOME") // see #2345
Expand Down