fix(toml): Force script edition warnings on quiet #16848
Merged
weihanglo merged 2 commits intorust-lang:masterfrom Apr 7, 2026
Merged
fix(toml): Force script edition warnings on quiet #16848weihanglo merged 2 commits intorust-lang:masterfrom
weihanglo merged 2 commits intorust-lang:masterfrom
Conversation
With closing of rust-lang#16598, we were stating that "unpinned edition" message should not be silenced. However, by default all warnings are silenced with `--quiet`. This also extends to `cargo foo.rs 2>&1 output.txt` because that implies `--quiet` for now until we are better able to limit the output of Cargo (see rust-lang#8889). This tty-dependent verbosity was not necessarily intended to silence this specific warning. This changes the edition warning so it is "forced" to always be displayed, regardless of verbosity, closing that hole for silencing it.
rustbot
added
A-manifest
Collaborator
|
r? @weihanglo rustbot has assigned @weihanglo. Use Why was this reviewer chosen?The reviewer was selected based on:
|
weihanglo
approved these changes
Apr 7, 2026
rustbot
removed
the
S-waiting-on-review
rust-bors bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
Apr 8, 2026
Cargo submodule update 11 commits in a357df4c26fc14514e66aae2a269456b5545c7db..101549dddbd2b08e806f50154e3aa4cb3374cc21 2026-04-03 16:47:15 +0000 to 2026-04-08 12:51:20 +0000 - Never include use extra-filename in build scripts (rust-lang/cargo#16855) - fix(toml): Force script edition warnings on quiet (rust-lang/cargo#16848) - GitHub fast path uses `http_async` (rust-lang/cargo#16847) - feat(manifest): allow git dependency alongside alternate registry (rust-lang/cargo#16810) - fix(auth): add auth scheme hint to token rejected error for alt registries (rust-lang/cargo#16794) - Warn on invalid jobserver file descriptors (rust-lang/cargo#16843) - docs(unstable): List the minimum required MSRV for 'public' field (rust-lang/cargo#16841) - feat(lints): Emit unused_dependencies lint (rust-lang/cargo#16600) - fix(tree): clarify error message when `-i` is used without a package name (rust-lang/cargo#16818) - fix: Typo in target.<cfg>.linker (rust-lang/cargo#16839) - Send Content-Type header with cargo publish requests (rust-lang/cargo#16832) r? ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
With closing of #16598, we were stating that "unpinned edition"
message should not be silenced.
However, by default all warnings are silenced with
--quiet.This also extends to
cargo foo.rs 2>&1 output.txtbecause that implies--quietfor now until we are better able to limit the output of Cargo(see #8889).
This tty-dependent verbosity was not necessarily intended to silence
this specific warning.
This changes the edition warning so it is "forced" to always be
displayed, regardless of verbosity, closing that hole for silencing it.
How to test and review this PR?