fix: detect circular publish dependency cycle in workspace publish by raushan728 · Pull Request #16722 · rust-lang/cargo

raushan728 · 2026-03-08T13:49:50Z

What does this PR try to resolve?

Detects circular publish dependency early and bails
with a clear error instead of silently timing out
with a blank warning message.

How to test and review this PR?

rustbot · 2026-03-08T13:49:54Z

r? @epage

rustbot has assigned @epage.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: @ehuss, @epage, @weihanglo
@ehuss, @epage, @weihanglo expanded to ehuss, epage, weihanglo
Random selection from ehuss, epage, weihanglo

tests/testsuite/publish.rs

src/cargo/ops/registry/publish.rs

tests/testsuite/publish.rs

src/cargo/ops/registry/publish.rs

raushan728 · 2026-03-10T10:15:26Z

I moved the cycle detection before the publish loop
by adding a has_cycles() method to PublishPlan that
checks if all packages have unmet dependencies
(weight > 0) but none are ready.

This way the error is thrown before any crate gets
published, avoiding a partially-published state.

All 133 publish tests pass with this approach.

src/cargo/ops/registry/publish.rs

tests/testsuite/publish.rs

raushan728 · 2026-03-11T06:36:15Z

Added cycle_members() to report only packages
actually forming the cycle, not all blocked ones
Replaced break with crate::util::internal()
for unexpected empty ready state
Added a second test verifying non-cycle package
is not mentioned in the error

tests/testsuite/publish.rs

… dependency

…imeout

raushan728 · 2026-03-17T02:42:26Z

@epage
cycle_members() now uses topological sort
with the original graph (dependent -> dependency).

c is correctly excluded from cycle members
Error is reported before any uploads occur

epage

Thanks!

View changes since this review

Update cargo submodule 13 commits in cbb9bb8bd0fb272b1be0d63a010701ecb3d1d6d3..d81735547e5f2844322f36380ab66f549cda11b9 2026-03-13 14:34:16 +0000 to 2026-03-20 13:20:51 +0000 - cargo clean: Validate that target_dir is not a file (rust-lang/cargo#16765) - fix: fetching non-standard git refspecs on non-github repos (rust-lang/cargo#16768) - Update tar to 0.4.45 (rust-lang/cargo#16771) - chore: Remove edition_lint_opts from Lint (rust-lang/cargo#16762) - refactor: split out several smaller changes to prepare for async http (rust-lang/cargo#16763) - fix(compile): Make build.warnings ignore non-local deps (rust-lang/cargo#16760) - fix: detect circular publish dependency cycle in workspace publish (rust-lang/cargo#16722) - refactor(shell): Pull out term integration into `anstyle-progress` (rust-lang/cargo#16757) - test: reproduce rustfix panic on overlapping suggestions (rust-lang/cargo#16705) - fix: Avoid panic for package specs with an empty fragment (rust-lang/cargo#16754) - refactor(registry): avoid dynamic dispatch for Registry trait (rust-lang/cargo#16752) - refactor(shell): Pull out hyperlink logic into anstyle-hyperlink (rust-lang/cargo#16749) - refactor(install): Remove dead code (rust-lang/cargo#16718) r? ghost

Update cargo submodule 14 commits in cbb9bb8bd0fb272b1be0d63a010701ecb3d1d6d3..e84cb639edfea2c42efd563b72a9be0cc5de6523 2026-03-13 14:34:16 +0000 to 2026-03-21 01:27:07 +0000 - Fix symlink_and_directory when running in a long target dir name (rust-lang/cargo#16775) - cargo clean: Validate that target_dir is not a file (rust-lang/cargo#16765) - fix: fetching non-standard git refspecs on non-github repos (rust-lang/cargo#16768) - Update tar to 0.4.45 (rust-lang/cargo#16771) - chore: Remove edition_lint_opts from Lint (rust-lang/cargo#16762) - refactor: split out several smaller changes to prepare for async http (rust-lang/cargo#16763) - fix(compile): Make build.warnings ignore non-local deps (rust-lang/cargo#16760) - fix: detect circular publish dependency cycle in workspace publish (rust-lang/cargo#16722) - refactor(shell): Pull out term integration into `anstyle-progress` (rust-lang/cargo#16757) - test: reproduce rustfix panic on overlapping suggestions (rust-lang/cargo#16705) - fix: Avoid panic for package specs with an empty fragment (rust-lang/cargo#16754) - refactor(registry): avoid dynamic dispatch for Registry trait (rust-lang/cargo#16752) - refactor(shell): Pull out hyperlink logic into anstyle-hyperlink (rust-lang/cargo#16749) - refactor(install): Remove dead code (rust-lang/cargo#16718)

rustbot assigned epage Mar 8, 2026

rustbot added A-interacts-with-crates.io Area: interaction with registries Command-publish S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 8, 2026