Skip to content

fix(timings): Only compute y_ticks when the units is not empty. #16575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weihanglo merged 1 commit into from
Jan 31, 2026
Merged

fix(timings): Only compute y_ticks when the units is not empty. #16575

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions src/cargo/core/compiler/timings/timings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,14 +531,17 @@ class SvgRenderer {
const axes = this._draw_graph_axes({ canvas_height, graph_height, graph_width, px_per_sec });

// Draw Y tick marks.
const path_commands = Array(units.length - 1)
.fill(0)
.map((_, idx) => {
const n = idx + 1;
const y = MARGIN + Y_TICK_DIST * n;
return `M${X_LINE} ${y} h-5`;
});
const y_ticks = `<path class="axis axis-y" d="${path_commands.join(" ")}"></path>`;
let y_ticks = '';
if (units.length != 0) {
const path_commands = Array(units.length - 1)
.fill(0)
.map((_, idx) => {
const n = idx + 1;
const y = MARGIN + Y_TICK_DIST * n;
return `M${X_LINE} ${y} h-5`;
});
y_ticks = `<path class="axis axis-y" d="${path_commands.join(" ")}"></path>`;
}

// Draw Y labels.
const y_labels = Array(units.length)
Expand Down