feat(lints): Add non_kebab_case_bin lint by epage · Pull Request #16524 · rust-lang/cargo

epage · 2026-01-16T23:09:31Z

What does this PR try to resolve?

How to test and review this PR?

Regarding lint naming:

I didn't go with non_kebab_case because we had received
encouragement to be more specific than non_camel_case when
discussing this at the All Hands
I went with bin rather than bin_name because the thing we are
ultimately linting is the binary file stem, not any specific field, and if
other fields end up contributing to the binary name, we should include
those, like
bin.namefilename
or any potential prefixes or suffixes

Regarding the lint's look: I tried to make this look as much like rustc
as possible:

    Checking cargo v0.95.0 (/home/epage/src/personal/cargo)
warning: function `Is_default_main` should have a snake case name
   --> src/cargo/lints/rules/non_kebab_case_bin.rs:188:4
    |
188 | fn Is_default_main(path: Option<&cargo_util_schemas::manifest::PathValue>) -> bool {
    |    ^^^^^^^^^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `is_default_main`
    |
    = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default

rustbot · 2026-01-16T23:09:36Z

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Muscraft · 2026-01-17T04:07:26Z

src/cargo/lints/rules/non_kebab_case_bin.rs

+            {
+                desc = desc.element(Snippet::source(contents).path(manifest_path).annotation(
+                    AnnotationKind::Primary.span(span.value).label(format!(
+                        "help: convert the bin name to kebab case: `{kebab_case}`"


I believe it is preferred to have help be its own Group

I was copying the existing rustc message style. Admittedly, rustc tends to not update every message as they evolve their style.

So which do we conform to?

I would prefer, for the time being, to have help be its own group. I think it makes it easier to differentiate the problem and the fix, at the expense of longer output. We can adjust things as we get feedback.

rustbot · 2026-01-20T20:45:21Z

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Regarding lint naming: - I didn't go with `non_kebab_case` because we had received encouragement to be more specific than `non_camel_case` when discussing this at the All Hands - I went with `bin` rather than `bin_name` because the thing we are ultimately linting is the binary file stem, not any specific field, and if other fields end up contributing to the binary name, we should include those, like [bin.namefilename](https://doc.rust-lang.org/cargo/reference/unstable.html#different-binary-name) or any potential [prefixes or suffixes](rust-lang#1970) Regarding the lint's look: I tried to make this look as much like rustc as possible: ``` Checking cargo v0.95.0 (/home/epage/src/personal/cargo) warning: function `Is_default_main` should have a snake case name --> src/cargo/lints/rules/non_kebab_case_bin.rs:188:4 | 188 | fn Is_default_main(path: Option<&cargo_util_schemas::manifest::PathValue>) -> bool { | ^^^^^^^^^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `is_default_main` | = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default ``` Fixes rust-lang#15586

Update cargo submodule 14 commits in 85eff7c80277b57f78b11e28d14154ab12fcf643..efcd9f58636c1990393d495159045d9c35e43b8f 2026-01-15 16:18:08 +0000 to 2026-01-23 13:50:59 +0000 - chore(deps): update cargo-semver-checks to v0.46.0 (rust-lang/cargo#16548) - Increase cache_lock test timeout (rust-lang/cargo#16545) - iTerm now supports OSC 9;4 (terminal window progress bar) (rust-lang/cargo#16506) - chore: Updated compiler errors for Rust 1.93 (rust-lang/cargo#16543) - test(build-std): adjust snapshot (rust-lang/cargo#16539) - chore: bump to 0.96.0 (rust-lang/cargo#16538) - fix: update `resolve_all_features()` to filter pkg deps (rust-lang/cargo#16221) - fix: show implicit_minimum_version_req emitted source once per package (rust-lang/cargo#16535) - fix: `--remap-path-scope` stabilized in 1.95-nightly (rust-lang/cargo#16536) - feat(lints): Add non_kebab_case_bin lint (rust-lang/cargo#16524) - fix(rm): Suggest table flags when none are specified (rust-lang/cargo#16533) - fix(patch): clean up patch-related error messages (rust-lang/cargo#16498) - Store artifact deps in build unit dir (rust-lang/cargo#16519) - refactor(timings): reuse timing metric collection logic between `--timings` and `-Zbuild-analysis` (rust-lang/cargo#16497)

epage added 2 commits January 16, 2026 16:54

refactor(lints): Allow indexing to get spans

0e2415d

test(lints): Add non_snake_case_bin_name tests

5cd00ce

rustbot assigned ehuss Jan 16, 2026

rustbot added A-manifest Area: Cargo.toml issues A-workspaces Area: workspaces S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 16, 2026

epage force-pushed the lint branch from dc65a64 to 98aa7c2 Compare January 17, 2026 00:45

Muscraft reviewed Jan 17, 2026

View reviewed changes

epage force-pushed the lint branch from 98aa7c2 to c2b0162 Compare January 20, 2026 20:30

This comment has been minimized.

Sign in to view

epage force-pushed the lint branch 2 times, most recently from 956a9a3 to 68e6f88 Compare January 20, 2026 20:45

epage added 2 commits January 20, 2026 14:53

chore(schemas): Bump version

bc5c41f

epage force-pushed the lint branch from 68e6f88 to 20c890e Compare January 20, 2026 20:54

rustbot added the A-documenting-cargo-itself Area: Cargo's documentation label Jan 20, 2026

epage force-pushed the lint branch 4 times, most recently from caa3f93 to 6a5bef2 Compare January 20, 2026 22:33

Muscraft approved these changes Jan 20, 2026

View reviewed changes

Muscraft enabled auto-merge January 20, 2026 22:49

Muscraft added this pull request to the merge queue Jan 20, 2026

Merged via the queue into rust-lang:master with commit 441c07d Jan 20, 2026
31 checks passed

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 20, 2026

epage deleted the lint branch January 22, 2026 02:00

weihanglo mentioned this pull request Jan 23, 2026

Update cargo submodule rust-lang/rust#151544

Merged

rustbot added this to the 1.95.0 milestone Jan 24, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(lints): Add non_kebab_case_bin lint #16524

feat(lints): Add non_kebab_case_bin lint #16524
Muscraft merged 4 commits intorust-lang:masterfrom
epage:lint

epage commented Jan 16, 2026

Uh oh!

rustbot commented Jan 16, 2026

Uh oh!

Muscraft Jan 17, 2026

Uh oh!

epage Jan 17, 2026

Uh oh!

epage Jan 17, 2026

Uh oh!

Muscraft Jan 19, 2026

Uh oh!

This comment has been minimized.

rustbot commented Jan 20, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

epage commented Jan 16, 2026

What does this PR try to resolve?

How to test and review this PR?

Uh oh!

rustbot commented Jan 16, 2026

Uh oh!

Muscraft Jan 17, 2026

Choose a reason for hiding this comment

Uh oh!

epage Jan 17, 2026

Choose a reason for hiding this comment

Uh oh!

epage Jan 17, 2026

Choose a reason for hiding this comment

Uh oh!

Muscraft Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

rustbot commented Jan 20, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants