Moved build-script bins to deps directory
#16515
Merged
+11
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-layout
Member
Author
hmmm, spurious failure? |
epage
reviewed
Jan 15, 2026
| pub fn build_script_execution(&self, pkg_dir: &str) -> PathBuf { | ||
| if self.is_new_layout { | ||
| self.build_unit(pkg_dir).join("build-script-execution") | ||
| self.build_unit(pkg_dir).join("build-script") |
Contributor
There was a problem hiding this comment.
I might even call this just run and generalize it beyond build scripts to executing some process.
epage
approved these changes
Jan 15, 2026
1 task
rustbot
removed
the
S-waiting-on-review
rust-bors bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
Jan 16, 2026
Update cargo submodule 15 commits in 8c133afcd5e0d69932fe11f5907683723f8d361d..85eff7c80277b57f78b11e28d14154ab12fcf643 2026-01-09 03:50:15 +0000 to 2026-01-15 16:18:08 +0000 - fix(lockfile): switch to `resolver.lockfile-path` config (rust-lang/cargo#16510) - Moved build-script bins to `deps` directory (rust-lang/cargo#16515) - Invalidate the whole build cache when `-Zno-embed-metadata` changes (rust-lang/cargo#16513) - Do not create examples dir in build dir with new layout (rust-lang/cargo#16514) - fix(git): avoid partial oid got zero padded (rust-lang/cargo#16511) - Optimize cargo locate-project --workspace (rust-lang/cargo#16423) - chore: Update typos (rust-lang/cargo#16507) - refactor(git): remove unnecessary serialization (rust-lang/cargo#16505) - fix(build-std): std link metadata propagate to user (rust-lang/cargo#16496) - Improve error message for missing dependencies (rust-lang/cargo#16500) - fix: preserve `dep_name` for build script metadata (rust-lang/cargo#16494) - refactor(toml): clarify `to_dependency` for config patch (rust-lang/cargo#16492) - Add `--id` flag to `cargo report timings` and `cargo report rebuilds` (rust-lang/cargo#16490) - Display lockfile path in very verbose mode when blocking (rust-lang/cargo#16491) - fix(info): resolve underscore vs hyphen mismatch in schema lookup (rust-lang/cargo#16455) r? ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
In #16502 (comment) there was a discussion about merging the
build-scriptanddepsdirs in thebuild-dir.Currently:
Note: For build-scripts
depsis empty.This PR:
build-scripttodepsto simplify the layoutbuild-script-executiontobuild-scriptto simplify the dir naming and shorten the path length for windowscc tracking issue: #15010
How to test and review this PR?
see the test changes
r? @epage