Skip to content

fix(git): avoid partial oid got zero padded #16511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
epage merged 2 commits into from
Jan 15, 2026
Merged

fix(git): avoid partial oid got zero padded #16511

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
489b174
fix(git): `src` in refspec must be full hash or a real ref
weihanglo Jan 15, 2026
4407f1a
fix(git): ensure GitHub responds full hash
weihanglo Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/cargo/sources/git/utils.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1007,7 +1007,7 @@ pub fn fetch(
fast_path_rev = true;
refspecs.push(format!("+{0}:refs/commit/{0}", oid_to_fetch));
} else if !matches!(shallow, gix::remote::fetch::Shallow::NoChange)
&& rev.parse::<Oid>().is_ok()
&& rev_to_oid(rev).is_some()
{
// There is a specific commit to fetch and we will do so in shallow-mode only
// to not disturb the previous logic.
Expand Down Expand Up @@ -1569,8 +1569,10 @@ fn github_fast_path(
if response_code == 304 {
debug!("github fast path up-to-date");
Ok(FastPathRev::UpToDate)
} else if response_code == 200 {
let oid_to_fetch = str::from_utf8(&response_body)?.parse::<Oid>()?;
} else if response_code == 200
&& let Some(oid_to_fetch) = rev_to_oid(str::from_utf8(&response_body)?)
{
// response expected to be a full hash hexstring (40 or 64 chars)
debug!("github fast path fetch {oid_to_fetch}");
Ok(FastPathRev::NeedsFetch(oid_to_fetch))
} else {
Expand Down