fix(report): get the same feature parity of `--timings` by weihanglo · Pull Request #16414 · rust-lang/cargo

weihanglo · 2025-12-18T02:24:50Z

What does this PR try to resolve?

After this cargo report timings has 99.9% of the feature parity of what --timings renders.

This adds some new fields to some events:

unit-registered
- features: a list of enabled features for the unit
unit-graph-finished
- requested_units: a list of user-requested units. Not calliing this root units because we may have synthetic "super-root" units in the future (like doc-merge, post-processing, or user-defined units), which people may care less and want to focus on what they are actually building.
build-started
- requested_platforms: alist of target platforms the build is for

The only thing left is CPU usage, but I don't consider it is a necessary.

Part of #15844

How to test and review this PR?

Rendered HTML snapshot

rustbot · 2025-12-18T02:24:55Z

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

...argo_report_timings/html_snapshot/out/cargo-timing-20060724T012128000Z-b0fd440798ab3cfb.html

epage · 2025-12-18T02:53:34Z

src/cargo/util/log_message.rs

        /// Build profile name (e.g., "dev", "release").
        profile: String,
+        /// The requested target platforms of compilation for this build.
+        requested_platforms: Vec<String>,


I feel like this belongs on the UnitRegistered messages. Once there, can we derive this?

Naming question: if in unit-registered, what should it call it:

platform

platform_target

target_platform:

target_triple (though for target-spec.json it won't be triple/tuple)

target

Also, we might want to rename the Cargo target to something

artifact (though it is weird that this is more close to the input than output)

build_target

This reminds me the thread: https://internals.rust-lang.org/t/renaming-cargo-target/21585/62. We definitely need to decide when stabilizing this.

Pick something and note it for stabilization?

The latest revision I chose to move forward with

target: build target

platform: platform target

epage · 2025-12-18T03:00:44Z

src/cargo/ops/cargo_compile/mod.rs

        let elapsed = ws.gctx().creation_time().elapsed().as_secs_f64();
-        logger.log(LogMessage::UnitGraphFinished { elapsed });
+        logger.log(LogMessage::UnitGraphFinished {
+            requested_units,


I like the name requested. I've been using selected but this works better.

src/cargo/ops/cargo_compile/mod.rs

This caused a headache that * You need to remember to generate timings report, otherwise the HTML get stale. * The source diff of both the log file and the HTML report are basically unreviewable, and the timestamp and elapsed time change every time. We'd like to find a better way to help review timing HTML instead of this.

This shows what `--timings` showing.

we additionally log this info in each `unit-registered` event

This is done by tracking unit-fingerprint events.

Done by having `requested: true` field in user-requested units Instead of calling it "root units", here we use "requested units", which represent the actual build targets that users requested. This is for reserving future extension that requested units may not always be the "root units" of the unit graph. We might have some synthetic units like rustdoc-merge, lipo universal binary for macOS, post-processing, or any user-defined super root units. The requested units sounds more future-proof than root_units,

Update cargo submodule 13 commits in e91b2baa632c0c7e84216c91ecfe107c37d887c1..3861f60f6b58f57524c0e7aab1f5c1ad83e35409 2025-12-13 16:29:21 +0000 to 2025-12-19 21:53:33 +0000 - fix(sbom): Don't set CARGO_SBOM_PATH when empty (like stable) (rust-lang/cargo#16419) - chore(ci): report-timings to upload HTML report (rust-lang/cargo#16416) - fix(report): get the same feature parity of `--timings` (rust-lang/cargo#16414) - fix(docs): Document the only possible values for DEBUG in build scripts (rust-lang/cargo#16413) - fix(log): emit fingeprint log also for no-rebuild unit (rust-lang/cargo#16408) - Fix link to `doc_cfg` docs in cargo book (rust-lang/cargo#16404) - Add best pratice for how to check in generated files (rust-lang/cargo#16405) - test: Use a larger default term width (rust-lang/cargo#16403) - Document more services and permissions of the cargo team (rust-lang/cargo#16402) - fix(new): Improve quality of package name error messages (rust-lang/cargo#16398) - feat(log): add more log events (rust-lang/cargo#16390) - chore: bump to 0.95.0; update changelog (rust-lang/cargo#16395) - Cache submodule into git db (rust-lang/cargo#16246) r? ghost

Update cargo submodule 17 commits in e91b2baa632c0c7e84216c91ecfe107c37d887c1..94c368ad2b9db0f0da5bdd8421cea13786ce4412 2025-12-13 16:29:21 +0000 to 2025-12-26 19:39:15 +0000 - fix(vendor): unpack from local-registry cache path (rust-lang/cargo#16435) - feat(index): Stabilize pubtime (rust-lang/cargo#16372) - Experiment: Render timing pipeline in SVG (rust-lang/cargo#15091) - chore(triagebot): auto-label `Command-report` (rust-lang/cargo#16429) - fix(sbom): Don't set CARGO_SBOM_PATH when empty (like stable) (rust-lang/cargo#16419) - chore(ci): report-timings to upload HTML report (rust-lang/cargo#16416) - fix(report): get the same feature parity of `--timings` (rust-lang/cargo#16414) - fix(docs): Document the only possible values for DEBUG in build scripts (rust-lang/cargo#16413) - fix(log): emit fingeprint log also for no-rebuild unit (rust-lang/cargo#16408) - Fix link to `doc_cfg` docs in cargo book (rust-lang/cargo#16404) - Add best pratice for how to check in generated files (rust-lang/cargo#16405) - test: Use a larger default term width (rust-lang/cargo#16403) - Document more services and permissions of the cargo team (rust-lang/cargo#16402) - fix(new): Improve quality of package name error messages (rust-lang/cargo#16398) - feat(log): add more log events (rust-lang/cargo#16390) - chore: bump to 0.95.0; update changelog (rust-lang/cargo#16395) - Cache submodule into git db (rust-lang/cargo#16246) r? ghost

Update cargo submodule 13 commits in e91b2baa632c0c7e84216c91ecfe107c37d887c1..3861f60f6b58f57524c0e7aab1f5c1ad83e35409 2025-12-13 16:29:21 +0000 to 2025-12-19 21:53:33 +0000 - fix(sbom): Don't set CARGO_SBOM_PATH when empty (like stable) (rust-lang/cargo#16419) - chore(ci): report-timings to upload HTML report (rust-lang/cargo#16416) - fix(report): get the same feature parity of `--timings` (rust-lang/cargo#16414) - fix(docs): Document the only possible values for DEBUG in build scripts (rust-lang/cargo#16413) - fix(log): emit fingeprint log also for no-rebuild unit (rust-lang/cargo#16408) - Fix link to `doc_cfg` docs in cargo book (rust-lang/cargo#16404) - Add best pratice for how to check in generated files (rust-lang/cargo#16405) - test: Use a larger default term width (rust-lang/cargo#16403) - Document more services and permissions of the cargo team (rust-lang/cargo#16402) - fix(new): Improve quality of package name error messages (rust-lang/cargo#16398) - feat(log): add more log events (rust-lang/cargo#16390) - chore: bump to 0.95.0; update changelog (rust-lang/cargo#16395) - Cache submodule into git db (rust-lang/cargo#16246) r? ghost

Update cargo submodule 17 commits in e91b2baa632c0c7e84216c91ecfe107c37d887c1..94c368ad2b9db0f0da5bdd8421cea13786ce4412 2025-12-13 16:29:21 +0000 to 2025-12-26 19:39:15 +0000 - fix(vendor): unpack from local-registry cache path (rust-lang/cargo#16435) - feat(index): Stabilize pubtime (rust-lang/cargo#16372) - Experiment: Render timing pipeline in SVG (rust-lang/cargo#15091) - chore(triagebot): auto-label `Command-report` (rust-lang/cargo#16429) - fix(sbom): Don't set CARGO_SBOM_PATH when empty (like stable) (rust-lang/cargo#16419) - chore(ci): report-timings to upload HTML report (rust-lang/cargo#16416) - fix(report): get the same feature parity of `--timings` (rust-lang/cargo#16414) - fix(docs): Document the only possible values for DEBUG in build scripts (rust-lang/cargo#16413) - fix(log): emit fingeprint log also for no-rebuild unit (rust-lang/cargo#16408) - Fix link to `doc_cfg` docs in cargo book (rust-lang/cargo#16404) - Add best pratice for how to check in generated files (rust-lang/cargo#16405) - test: Use a larger default term width (rust-lang/cargo#16403) - Document more services and permissions of the cargo team (rust-lang/cargo#16402) - fix(new): Improve quality of package name error messages (rust-lang/cargo#16398) - feat(log): add more log events (rust-lang/cargo#16390) - chore: bump to 0.95.0; update changelog (rust-lang/cargo#16395) - Cache submodule into git db (rust-lang/cargo#16246) r? ghost

weihanglo added the Z-build-analysis Nightly: build-analysis label Dec 18, 2025

rustbot assigned ehuss Dec 18, 2025

rustbot added A-timings Area: timings S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 18, 2025

epage reviewed Dec 18, 2025

View reviewed changes

...argo_report_timings/html_snapshot/out/cargo-timing-20060724T012128000Z-b0fd440798ab3cfb.html Outdated Show resolved Hide resolved

epage reviewed Dec 18, 2025

View reviewed changes

src/cargo/ops/cargo_compile/mod.rs Outdated Show resolved Hide resolved

weihanglo added 7 commits December 18, 2025 16:30

refactor(report): prepare metadata in unit-registered event

09bf023

fix(report): show the first line of rustc -vV

25d703f

This shows what `--timings` showing.

fix(report): show the requested target platforms

2ebf882

we additionally log this info in each `unit-registered` event

fix(report): show fingerprint dirty fresh count

2f39f17

This is done by tracking unit-fingerprint events.

fix(report): track enabled features in unit-registered events

725980d

weihanglo force-pushed the more-data branch from 4702fc0 to 40613e1 Compare December 18, 2025 21:35

weihanglo mentioned this pull request Dec 18, 2025

Tracking Issue for -Zbuild-analysis #15844

Open

25 tasks

epage approved these changes Dec 18, 2025

View reviewed changes

epage added this pull request to the merge queue Dec 18, 2025

Merged via the queue into rust-lang:master with commit f4266b7 Dec 18, 2025
28 checks passed

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 18, 2025

weihanglo mentioned this pull request Dec 20, 2025

Update cargo submodule rust-lang/rust#150181

Merged

rustbot added this to the 1.94.0 milestone Dec 20, 2025

This was referenced Dec 26, 2025

Prototype Cargo build analysis rust-lang/rust-project-goals#398

Open

Update cargo submodule rust-lang/rust#150421

Merged

weihanglo deleted the more-data branch December 29, 2025 21:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(report): get the same feature parity of `--timings`#16414

fix(report): get the same feature parity of `--timings`#16414
epage merged 7 commits intorust-lang:masterfrom
weihanglo:more-data

weihanglo commented Dec 18, 2025

Uh oh!

rustbot commented Dec 18, 2025

Uh oh!

Uh oh!

epage Dec 18, 2025

Uh oh!

weihanglo Dec 18, 2025

Uh oh!

epage Dec 18, 2025

Uh oh!

weihanglo Dec 18, 2025

Uh oh!

epage Dec 18, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

weihanglo commented Dec 18, 2025

What does this PR try to resolve?

How to test and review this PR?

Uh oh!

rustbot commented Dec 18, 2025

Uh oh!

Uh oh!

epage Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

weihanglo Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

epage Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

weihanglo Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

epage Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants