-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Revert "feat: Do not lock the artifact-dir for check builds" #16299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+29
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9f5393a. Fixes rust-lang#16297
Collaborator
ranger-ross
approved these changes
Nov 25, 2025
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
weihanglo
approved these changes
Nov 25, 2025
Member
|
Thanks!. I'll do a submodule update later today. |
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Nov 26, 2025
Update cargo submodule 7 commits in 9fa462fe3a81e07e0bfdcc75c29d312c55113ebb..2a7c4960677971f88458b0f8b461a866836dff59 2025-11-21 20:49:51 +0000 to 2025-11-25 19:58:07 +0000 - docs(config-include): prepare for doc stabilization (rust-lang/cargo#16301) - fix(config-include): remove support of single string shorthand (rust-lang/cargo#16298) - Revert "feat: Do not lock the artifact-dir for check builds" (rust-lang/cargo#16299) - clean: Add --workspace support (rust-lang/cargo#16263) - feat(tree): Add more native completions (rust-lang/cargo#16296) - fix(package): exclude target/package from backups (rust-lang/cargo#16272) - test: re-enable test since not flaky anymore (rust-lang/cargo#16287)
github-actions bot
pushed a commit
to rust-lang/compiler-builtins
that referenced
this pull request
Nov 27, 2025
Update cargo submodule 7 commits in 9fa462fe3a81e07e0bfdcc75c29d312c55113ebb..2a7c4960677971f88458b0f8b461a866836dff59 2025-11-21 20:49:51 +0000 to 2025-11-25 19:58:07 +0000 - docs(config-include): prepare for doc stabilization (rust-lang/cargo#16301) - fix(config-include): remove support of single string shorthand (rust-lang/cargo#16298) - Revert "feat: Do not lock the artifact-dir for check builds" (rust-lang/cargo#16299) - clean: Add --workspace support (rust-lang/cargo#16263) - feat(tree): Add more native completions (rust-lang/cargo#16296) - fix(package): exclude target/package from backups (rust-lang/cargo#16272) - test: re-enable test since not flaky anymore (rust-lang/cargo#16287)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
Fixes #16297
How to test and review this PR?
This reverts commit 9f5393a.