Add http.proxy-cainfo config for proxy certs
#15374
Conversation
This adds a `http.proxy-cainfo` option to Cargo which reads CA information from a bundle to pass through to the underlying `libcurl` call. This should allow configuration of Cargo in situations where SSL proxy is used.
|
r? @weihanglo rustbot has assigned @weihanglo. Use |
rustbot
added
A-configuration
There was a problem hiding this comment.
Thanks. This looks reasonable, though I saw your comment in #13460 (comment), and wonder what people want.
Do people really need the ability to configure custom proxy CA info, or just want to disable all the CA checks?
There is also git's CA check discussion in #1180 as well, somehow relevant.
There was a problem hiding this comment.
See #13460 (comment).
Let's discuss over there :)
There was a problem hiding this comment.
I don't want to disable CA checks - although I think it is really useful option, definitely worth introducing.
There was a problem hiding this comment.
I faced the problem where cargo doesn't work with an SSL proxy, even though the custom CA is trusted (curl doesn't complain about the certificates). This stems from the fact that the automatically vendored libcurl has no built-in information about the system trust store. I wrote a fairly detailed description of this issue in #15376; the ability to set a proxy cainfo is a real need to solve it.
This adds a
http.proxy-cainfooption to Cargo which reads CA information from a bundle to pass through to the underlyinglibcurlcall. This should allow configuration of Cargo in situations where SSL proxy is used.Similar to #2917.