-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] chore: add aarch64 linux runner #15077
base: master
Are you sure you want to change the base?
Conversation
.github/workflows/main.yml
Outdated
@@ -155,6 +163,9 @@ jobs: | |||
- uses: actions/checkout@v4 | |||
- name: Dump Environment | |||
run: ci/dump-environment.sh | |||
# workaround for https://github.com/actions/partner-runner-images/issues/26 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the linked issue, it's available/fixed now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I re-ran the tests and everything passed except cross compile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current arm machine sometimes throws a random free()
allocation error. I lost the exact build failure, but feel like it is not really stable yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Investigation into compilation problems are currently being investigated in rust-lang/rust#135867.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
free(): invalid next size (fast)
It doesn't seem to be a compilation error though.
Linux arm64 hosted runners is in public preview. Enable and see if is is something we can have now. setting `target.linker` is required for cross-compilation on ARM64, so disable cross compilation tests for it. https://github.blog/changelog/2025-01-16-linux-arm64-hosted-runners-now-available-for-free-in-public-repositories-public-preview/
What does this PR try to resolve?
Linux arm64 hosted runners is in public preview.
Enable and see if is is something we can have now.
https://github.blog/changelog/2025-01-16-linux-arm64-hosted-runners-now-available-for-free-in-public-repositories-public-preview/
How should we test and review this PR?
aarch64-unknown-linux-gnu is a tier-1 target platform.
It is better to have this in Cargo's CI.
Additional information
https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/Free.20Linux.20ARM64.20runners.20on.20GHA.20now.20in.20beta