-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(toml): Update frontmatter parser for RFC 3503 #14792
Merged
Merged
Commits on Nov 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f018624 - Browse repository at this point
Copy the full SHA f018624View commit details -
Configuration menu - View commit details
-
Copy full SHA for d769cb5 - Browse repository at this point
Copy the full SHA d769cb5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ea0d97 - Browse repository at this point
Copy the full SHA 2ea0d97View commit details
Commits on Nov 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c88c789 - Browse repository at this point
Copy the full SHA c88c789View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8c88f23 - Browse repository at this point
Copy the full SHA 8c88f23View commit details -
Configuration menu - View commit details
-
Copy full SHA for 45c2ff8 - Browse repository at this point
Copy the full SHA 45c2ff8View commit details -
refactor(toml): Preserve the full newline for shebang
The shebang is thrown away so this has no end-user impact
Configuration menu - View commit details
-
Copy full SHA for 51db441 - Browse repository at this point
Copy the full SHA 51db441View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8918634 - Browse repository at this point
Copy the full SHA 8918634View commit details -
fix(toml): Don't error on leading whitespace in infostring
According to the [RFC](https://rust-lang.github.io/rfcs/3503-frontmatter.html): > Opens with 3+ dashes followed by 0+ whitespace, > an optional term (one or more characters excluding whitespace and commas), > 0+ whitespace, and a newline
Configuration menu - View commit details
-
Copy full SHA for c1248ad - Browse repository at this point
Copy the full SHA c1248adView commit details -
fix(toml): Strip blank linkes before frontmatter
From the [RFC](https://rust-lang.github.io/rfcs/3503-frontmatter.html) > When parsing Rust source, after stripping the shebang (#!), rustc will strip the frontmatter: > > - May include 0+ blank lines (whitespace + newline) The question is what is a non-newline whitespace and what is a newline. Looking at the [Reference](https://doc.rust-lang.org/reference/whitespace.html), the answer is "unsure", particularly because the Rust language doesn't generally try to distinguish them. I kept things basic for now and we can revisit later.
Configuration menu - View commit details
-
Copy full SHA for 82836b0 - Browse repository at this point
Copy the full SHA 82836b0View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.