Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more profiling traces #14238

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Add more profiling traces #14238

merged 1 commit into from
Jul 11, 2024

Commits on Jul 11, 2024

  1. Add more profiling traces

    Someone suggested I look at
    [zed](https://github.com/zed-industries/zed).
    It has some interesting performance characteristics compared to projects
    I looked at before:
    - A lot of workspace members
    - git dependencies
    - patches
    
    This adds traces that help provide more context for those scenarios when
    looking at them.
    
    Some of these areas might be of interest for
    optimizing:
    - On every invocation, we do a git2 `copy_to` call for each git checkout
    - On every invocation, we do a `du` on each git checkout
    - It'd be great to avoid parsing every manifest in a git checkout but we
      need to do a full parse to make sure we find all packages (see
      https://rust-lang.zulipchat.com/#narrow/stream/246057-t-cargo/topic/Redundant.20code.20in.20.60GitSouce.60.3F)
    - Its suspicious how much time we spend in the "poison" step of
      resolving when its a no-op
    epage committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    89eb406 View commit details
    Browse the repository at this point in the history